unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 57699@debbugs.gnu.org
Subject: bug#57699: Assertion failure "lib_child_handler != dummy_handler"
Date: Fri, 09 Sep 2022 11:27:07 -0400	[thread overview]
Message-ID: <jwvy1usvab3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fsh07fwm.fsf@gmail.com> (Robert Pluim's message of "Fri, 09 Sep 2022 16:59:05 +0200")

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

> EEMPTYPATCH

Hmm... not sure how that happened.
Let's try again.


        Stefan

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lib_child_handler.patch --]
[-- Type: text/x-diff, Size: 980 bytes --]

diff --git a/src/process.c b/src/process.c
index 7a133cda00f..331f7daf83e 100644
--- a/src/process.c
+++ b/src/process.c
@@ -8438,11 +8438,15 @@ init_process_emacs (int sockfd)
       catch_child_signal ();
       g_source_unref (source);
 
-      eassert (lib_child_handler != dummy_handler);
-      signal_handler_t lib_child_handler_glib = lib_child_handler;
-      catch_child_signal ();
-      eassert (lib_child_handler == dummy_handler);
-      lib_child_handler = lib_child_handler_glib;
+      /* Apparently more recent versions of glib do not set this handler
+         any more, so make sure the dance is needed before going for it.  */
+      if (lib_child_handler != dummy_handler)
+        {
+          signal_handler_t lib_child_handler_glib = lib_child_handler;
+          catch_child_signal ();
+          eassert (lib_child_handler == dummy_handler);
+          lib_child_handler = lib_child_handler_glib;
+        }
 #else
       catch_child_signal ();
 #endif

  reply	other threads:[~2022-09-09 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 14:40 bug#57699: Assertion failure "lib_child_handler != dummy_handler" Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-09 14:59 ` Robert Pluim
2022-09-09 15:27   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-09 17:13     ` Lars Ingebrigtsen
2022-09-09 21:27       ` Paul Eggert via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-11 11:38         ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-11 11:47           ` Eli Zaretskii
2022-09-11 13:54             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-11 14:51               ` Paul Eggert via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy1usvab3.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=57699@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).