From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57699: Assertion failure "lib_child_handler != dummy_handler" Date: Fri, 09 Sep 2022 11:27:07 -0400 Message-ID: References: <87fsh07fwm.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57699@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 09 17:28:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWfvP-0007YV-OP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 17:28:11 +0200 Original-Received: from localhost ([::1]:46172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWfvO-0000j7-Ne for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 11:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWfvG-0000iU-Qi for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 11:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWfvG-00052s-Hr for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWfvG-0003f8-DC for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Sep 2022 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57699-submit@debbugs.gnu.org id=B57699.166273723814011 (code B ref 57699); Fri, 09 Sep 2022 15:28:02 +0000 Original-Received: (at 57699) by debbugs.gnu.org; 9 Sep 2022 15:27:18 +0000 Original-Received: from localhost ([127.0.0.1]:35053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWfuY-0003du-DZ for submit@debbugs.gnu.org; Fri, 09 Sep 2022 11:27:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWfuW-0003dg-69 for 57699@debbugs.gnu.org; Fri, 09 Sep 2022 11:27:17 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5347780762; Fri, 9 Sep 2022 11:27:10 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E704D8019D; Fri, 9 Sep 2022 11:27:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662737228; bh=IvQx4WblDOrHyRnm4ArMo1JZJzeqP09idyyTAnWFFMs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MnO+JbikweW8pB8/Ond2ziKH5+an+4h4UsQN7K5QN46gLELQO/CdgPji63FFotPgE MQCJIp8dkJuTZYz7qX9NizOOU+fXSnJRLhhwSPNvQo5Vbw75bw9PeyWmbnBaS75NiB 2iPIUwZ6mDD1jdLRxqtBNF6ovwbfYWkNsTq6t3LKv595w4Nr+iZ9uDXMlEEsnNKJKA EtQ1ZwiHY0Z1MYvXh1vdVciNRW+cX+PKa78xkM6N23E8cYz9G7TuEx40ISked8ggQ3 leiGUcaEOfezx/UQfnA6/UV3FxRFgP6ZaKrjzexFqVXlBzOR9Kmuc1y7ls3She6UtP ImNLbRoTIXcKw== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE5DF120813; Fri, 9 Sep 2022 11:27:08 -0400 (EDT) In-Reply-To: <87fsh07fwm.fsf@gmail.com> (Robert Pluim's message of "Fri, 09 Sep 2022 16:59:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241990 Archived-At: --=-=-= Content-Type: text/plain > EEMPTYPATCH Hmm... not sure how that happened. Let's try again. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lib_child_handler.patch diff --git a/src/process.c b/src/process.c index 7a133cda00f..331f7daf83e 100644 --- a/src/process.c +++ b/src/process.c @@ -8438,11 +8438,15 @@ init_process_emacs (int sockfd) catch_child_signal (); g_source_unref (source); - eassert (lib_child_handler != dummy_handler); - signal_handler_t lib_child_handler_glib = lib_child_handler; - catch_child_signal (); - eassert (lib_child_handler == dummy_handler); - lib_child_handler = lib_child_handler_glib; + /* Apparently more recent versions of glib do not set this handler + any more, so make sure the dance is needed before going for it. */ + if (lib_child_handler != dummy_handler) + { + signal_handler_t lib_child_handler_glib = lib_child_handler; + catch_child_signal (); + eassert (lib_child_handler == dummy_handler); + lib_child_handler = lib_child_handler_glib; + } #else catch_child_signal (); #endif --=-=-=--