bug#9789: [patch] adding the option --without-compress-el to configure

bug#9789: [patch] adding the option --without-compress-el to configure

[OKAZAKI Tetsurou]

Hi,

On Cygwin with low voltage notebooks, `make install' takes long time
to compress the Lisp source files.

Attached patch adds new configure option `--without-compress-el' which
suppresses automatic compression of the *.el files.


=== modified file 'Makefile.in'
*** Makefile.in	2011-09-26 21:30:18 +0000
--- Makefile.in	2011-10-13 12:14:10 +0000
*************** INSTALL_STRIP =
*** 243,248 ****
--- 243,250 ----
  
  # We use gzip to compress installed .el files.
  GZIP_PROG = @GZIP_PROG@
+ # If non-nil, gzip the installed el files.
+ GZIP_EL = @GZIP_EL@
  # If non-nil, gzip the installed Info and man pages.
  GZIP_INFO = @GZIP_INFO@
  
*************** install-arch-indep: mkdir info install-e
*** 597,603 ****
  	    find . -exec chown $${installuser} {} ';') ; \
  	else true; fi
  	-unset CDPATH; \
! 	if [ -n "${GZIP_PROG}" ]; \
  	then \
  	   echo "Compressing *.el ..." ; \
  	   (cd $(DESTDIR)${lispdir}; for f in `find . -name "*.elc" -print`; do \
--- 599,605 ----
  	    find . -exec chown $${installuser} {} ';') ; \
  	else true; fi
  	-unset CDPATH; \
! 	if [ -n "${GZIP_EL}" ] && [ -n "${GZIP_PROG}" ]; \
  	then \
  	   echo "Compressing *.el ..." ; \
  	   (cd $(DESTDIR)${lispdir}; for f in `find . -name "*.elc" -print`; do \

=== modified file 'configure.in'
*** configure.in	2011-10-18 18:12:53 +0000
--- configure.in	2011-10-18 22:28:21 +0000
*************** else
*** 192,197 ****
--- 192,205 ----
  fi
  AC_SUBST(GZIP_INFO)
  
+ OPTION_DEFAULT_ON([compress-el],[don't compress the installed el files])
+ if test $with_compress_el = yes; then
+    GZIP_EL=yes
+ else
+    GZIP_EL=
+ fi
+ AC_SUBST(GZIP_EL)
+ 
  AC_ARG_WITH([pkg-config-prog],dnl
  [AS_HELP_STRING([--with-pkg-config-prog=PATH],
                    [path to pkg-config for finding GTK and librsvg])])

bug#9789: [patch] adding the option --without-compress-el to configure

[Stefan Monnier]

> On Cygwin with low voltage notebooks, `make install' takes long time
> to compress the Lisp source files.

What percentage of the total time are we talking about?


        Stefan

bug#9789: [patch] adding the option --without-compress-el to configure

[Paul Eggert]

I don't know about low-power laptops, but on my low-power desktop
(Fedora 15, AMD Phenom II X4 910e, 65W 2.6 GHz), "make install"
takes 21 seconds real-time without compression, and
44 seconds with compression.

I install without compression by using the shell command
"make GZIP_PROG= install".  That's pretty simple; do we
need a configure-time option too?

We could speed up "make install" considerably by
parallelizing it better, but that's a different topic.

bug#9789: [patch] adding the option --without-compress-el to configure

[OKAZAKI Tetsurou]

At Tue, 18 Oct 2011 23:46:22 -0400,
Stefan Monnier wrote:
> 
> > On Cygwin with low voltage notebooks, `make install' takes long time
> > to compress the Lisp source files.
> 
> What percentage of the total time are we talking about?

About 40 percent.  Below is the result of `time make install':

--with-compress-el (default)

real    30m45.598s
user    3m51.413s
sys     11m59.457s


--without-compress-el

real    17m5.293s
user    1m59.270s
sys     6m43.657s

--
Tetsurou

bug#9789: [patch] adding the option --without-compress-el to configure

[Stefan Monnier]

>> > On Cygwin with low voltage notebooks, `make install' takes long time
>> > to compress the Lisp source files.
>> What percentage of the total time are we talking about?
> About 40 percent.  Below is the result of `time make install':

> --with-compress-el (default)

> real    30m45.598s
> user    3m51.413s
> sys     11m59.457s


> --without-compress-el

> real    17m5.293s
> user    1m59.270s
> sys     6m43.657s

I would think that the only relevant percentage is of total
compile+install time, since it's rather rare to install repeatedly
without compiling.

Or maybe I don't understand the intended use case (I can't remember the
last time I ran "make install" to tell you the truth).


        Stefan

bug#9789: [patch] adding the option --without-compress-el to configure

[Lars Magne Ingebrigtsen]

Paul Eggert <eggert@cs.ucla.edu> writes:

> I install without compression by using the shell command
> "make GZIP_PROG= install".  That's pretty simple; do we
> need a configure-time option too?

That does seem like a better solution than adding yet another config
option, so I'm closing this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#9789: [patch] adding the option --without-compress-el to configure

[Jan D.]

Lars Magne Ingebrigtsen skrev 2012-04-11 13:36:
> Paul Eggert<eggert@cs.ucla.edu>  writes:
>
>> I install without compression by using the shell command
>> "make GZIP_PROG= install".  That's pretty simple; do we
>> need a configure-time option too?
>
> That does seem like a better solution than adding yet another config
> option, so I'm closing this report.
>

But on the other hand you have to specify the configure option once, but 
the GZIP_PROG= many times.  Maybe this is only a problem for developers.

	Jan D.