unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, Stefan Kangas <stefan@marxist.se>,
	"Basil L. Contovounesios" <contovob@tcd.ie>,
	dick.r.chiang@gmail.com, 46722@debbugs.gnu.org,
	Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>
Subject: bug#46722: test-map-into fails
Date: Sat, 15 Jan 2022 10:16:48 -0500	[thread overview]
Message-ID: <jwvwnj1jant.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAArVCkTiHSATXbpRNqMQqs8CGEKL3wrVdZ_6gajKpjUsFAjgog@mail.gmail.com> (Philipp Stephani's message of "Sat, 15 Jan 2022 12:47:33 +0100")

FWIW, I think installing the cl-generic patch into `emacs-28` would be
a much better option.  In my view it's "super safe" and it fixes
a nasty bug that can affect a lot of code (as we're witnessing here
with those test problems).

It admittedly doesn't fix a regression.

For reference the patch is just:

    diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
    index 983694204df..5090e060372 100644
    --- a/lisp/emacs-lisp/cl-generic.el
    +++ b/lisp/emacs-lisp/cl-generic.el
    @@ -604,7 +604,9 @@ cl--generic-dispatchers
     
     (defun cl--generic-get-dispatcher (dispatch)
       (with-memoization
    -      (gethash dispatch cl--generic-dispatchers)
    +      ;; We need `copy-sequence` here because this `dispatch' object might be
    +      ;; modified by side-effect in `cl-generic-define-method' (bug#46722).
    +      (gethash (copy-sequence dispatch) cl--generic-dispatchers)
         ;; (message "cl--generic-get-dispatcher (%S)" dispatch)
         (let* ((dispatch-arg (car dispatch))
                (generalizers (cdr dispatch))

It's already the second time I say it, so I promise it's the last time
I insist here.  I can live with either choice, but I'm sure Emacs-28 will
be better off with the patch than without.


        Stefan






  reply	other threads:[~2022-01-15 15:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 16:22 bug#46722: test-map-into fails Glenn Morris
2021-02-23 16:33 ` Basil L. Contovounesios
2021-02-23 17:06   ` Glenn Morris
2021-02-23 17:30   ` Stefan Monnier
2021-02-23 20:58     ` Basil L. Contovounesios
2021-02-23 22:50       ` Basil L. Contovounesios
2021-04-04 16:05 ` Glenn Morris
2021-11-17  8:47 ` Stefan Kangas
2021-11-29 18:20   ` Glenn Morris
2021-11-29 18:26     ` Lars Ingebrigtsen
2021-11-29 18:40       ` Glenn Morris
2022-01-04 21:56         ` dick
2022-01-05 14:01           ` dick
2022-01-05 16:31             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 17:51               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:07                 ` Eli Zaretskii
2022-01-05 18:24                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 19:23                     ` Philipp Stephani
2022-01-13 20:40                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 20:45                         ` Philipp Stephani
2022-01-14  7:40                           ` Lars Ingebrigtsen
2022-01-14 12:02                             ` Philipp Stephani
2022-01-15  8:01                               ` Lars Ingebrigtsen
2022-01-15 11:47                                 ` Philipp Stephani
2022-01-15 15:16                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-01-15 15:55                                     ` Eli Zaretskii
2022-01-20 12:49                                       ` Lars Ingebrigtsen
2022-01-05 15:17           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 16:04             ` dick
2022-01-05 16:38               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:35           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:59             ` dick
2022-01-05 19:17               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwnj1jant.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=46722@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=dick.r.chiang@gmail.com \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=p.stephani2@gmail.com \
    --cc=rgm@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).