unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: dick <dick.r.chiang@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, smonnier <smonnier@iro.umontreal.ca>,
	Stefan Kangas <stefan@marxist.se>,
	contovob@tcd.ie, 46722@debbugs.gnu.org,
	Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#46722: test-map-into fails
Date: Wed, 05 Jan 2022 10:17:19 -0500	[thread overview]
Message-ID: <jwvr19mrzb2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87czl7w4fh.fsf@dick> (dick's message of "Tue, 04 Jan 2022 16:56:34 -0500")

> You can't do,
>
> (funcall
>  (funcall
>   (backquote
>    (lambda (arg)
>      (lambda () arg)))
>   t))
>
> which is what `cl--generic-get-dispatcher` tries to do.

Is it?  Where does `cl--generic-get-dispatcher` do that?

Oh, you mean we don't guarantee that we use static scoping?
I think I see what mean.
Does the patch below help?


        Stefan


diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 983694204df..686a2375971 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -644,7 +644,8 @@ cl--generic-get-dispatcher
       ;; FIXME: For generic functions with a single method (or with 2 methods,
       ;; one of which always matches), using a tagcode + hash-table is
       ;; overkill: better just use a `cl-typep' test.
-      (byte-compile
+      (funcall
+       (lambda (exp) (let ((lexical-binding t)) (byte-compile exp)))
        `(lambda (generic dispatches-left methods)
           ;; FIXME: We should find a way to expand `with-memoize' once
           ;; and forall so we don't need `subr-x' when we get here.






  parent reply	other threads:[~2022-01-05 15:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 16:22 bug#46722: test-map-into fails Glenn Morris
2021-02-23 16:33 ` Basil L. Contovounesios
2021-02-23 17:06   ` Glenn Morris
2021-02-23 17:30   ` Stefan Monnier
2021-02-23 20:58     ` Basil L. Contovounesios
2021-02-23 22:50       ` Basil L. Contovounesios
2021-04-04 16:05 ` Glenn Morris
2021-11-17  8:47 ` Stefan Kangas
2021-11-29 18:20   ` Glenn Morris
2021-11-29 18:26     ` Lars Ingebrigtsen
2021-11-29 18:40       ` Glenn Morris
2022-01-04 21:56         ` dick
2022-01-05 14:01           ` dick
2022-01-05 16:31             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 17:51               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:07                 ` Eli Zaretskii
2022-01-05 18:24                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 19:23                     ` Philipp Stephani
2022-01-13 20:40                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 20:45                         ` Philipp Stephani
2022-01-14  7:40                           ` Lars Ingebrigtsen
2022-01-14 12:02                             ` Philipp Stephani
2022-01-15  8:01                               ` Lars Ingebrigtsen
2022-01-15 11:47                                 ` Philipp Stephani
2022-01-15 15:16                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-15 15:55                                     ` Eli Zaretskii
2022-01-20 12:49                                       ` Lars Ingebrigtsen
2022-01-05 15:17           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-01-05 16:04             ` dick
2022-01-05 16:38               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:35           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-05 18:59             ` dick
2022-01-05 19:17               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr19mrzb2.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=46722@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=dick.r.chiang@gmail.com \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    --cc=smonnier@iro.umontreal.ca \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).