From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>, 66908@debbugs.gnu.org
Subject: bug#66908: Exposing more public nadvice API
Date: Sat, 04 Nov 2023 04:13:51 -0400 [thread overview]
Message-ID: <jwvwmuy7xt9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wmuydobs.fsf@gmail.com> (Visuwesh's message of "Sat, 04 Nov 2023 11:58:39 +0530")
> Sure, in Philip's package do-at-point, a function defined to "act" on
> the `thing' at point are given different arguments depending on the
> minimum number of arguments required by the function:
Ah :-(
So a kind of "unimplementable semantics" for DWIM purposes.
> (pcase (car (func-arity func))
> ^^^^^^^^^^^^^^^^^
> (0 (funcall func))
> (1 (funcall func (buffer-substring (car bound) (cdr bound))))
> (2 (funcall func (car bound) (cdr bound)))
> (_ (error "Unsupported signature: %S" func)))))
I recommend:
(condition-case nil
(funcall func (car bound) (cdr bound))
(wrong-number-of-arguments
(condition-case nil
(funcall func (buffer-substring (car bound) (cdr bound)))
(wrong-number-of-arguments
(funcall func)))))
:-)
Works with advice and other wrappers without having to worry about
`indirect-function`, autoloading, etc...
>>> (func-arity (advice--cd*r (indirect-function 'xref-find-definitions))) ;; ⇒ (1 . 1)
>>> which is the right return value. It might be nice to not have to call
>>> `indirect-function' here for the "global" function but you can be a
>>> better judge of that.
>> Don't know what you mean by "global" function.
> By "global", I mean the new global function advice-cd*r or somesuch that
> might eventually be added from this discussion.
Ah, I see. I don't think `advice-cd*r` should follow aliases in
general. But indeed, you may have an `advice` object whose
`advice-cd*r` is a symbol, whose definition is another advice object,
etc...
Another good reason to prefer the `condition-case` approach :-)
>> By "autoloaded" do you mean "setup to be loaded on demand but not yet
>> loaded", or do you mean "had been setup to be loaded on demand and has
>> been loaded already"?
> The former obviously.
In that case, `indirect-function` would not see the advice, then
`func-arity` would cause the target to be (auto)loaded, during which
a previously pending advice could be installed and it would return the
dreaded (0 . many) from the advice it sees in the definition.
Again, using `condition-case` side steps the issue.
Stefan
next prev parent reply other threads:[~2023-11-04 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 8:34 bug#66908: Exposing more public nadvice API Philip Kaludercic
2023-11-03 16:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-03 18:50 ` Visuwesh
2023-11-03 19:24 ` Drew Adams
2023-11-03 22:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 2:48 ` Visuwesh
2023-11-04 6:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 6:28 ` Visuwesh
2023-11-04 8:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-04 9:58 ` Philip Kaludercic
2023-11-04 15:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmuy7xt9.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=66908@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).