From: Visuwesh <visuweshm@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Philip Kaludercic <philipk@posteo.net>, 66908@debbugs.gnu.org
Subject: bug#66908: Exposing more public nadvice API
Date: Sat, 04 Nov 2023 11:58:39 +0530 [thread overview]
Message-ID: <87wmuydobs.fsf@gmail.com> (raw)
In-Reply-To: <jwvo7ga9hpi.fsf-monnier+emacs@gnu.org> (Stefan Monnier via's message of "Sat, 04 Nov 2023 02:14:46 -0400")
[சனி நவம்பர் 04, 2023] Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>>> Could you describe the circumstance where you need it?
>> We need to get the func-arity of the original function and not its
>> advice.
>
> That's the part I'd been (indirectly) told already. What I meant was
> why do you need to find the arity of that(those) function(s)?
Sure, in Philip's package do-at-point, a function defined to "act" on
the `thing' at point are given different arguments depending on the
minimum number of arguments required by the function:
(let* ((thing (overlay-get do-at-point--overlay 'do-at-point-thing))
(options (do-at-point--actions thing))
(choice ...)
(func (cadr (alist-get (car choice) options)))
(bound (cons (overlay-start do-at-point--overlay)
(overlay-end do-at-point--overlay))))
(when func
(pcase (car (func-arity func))
^^^^^^^^^^^^^^^^^
(0 (funcall func))
(1 (funcall func (buffer-substring (car bound) (cdr bound))))
(2 (funcall func (car bound) (cdr bound)))
(_ (error "Unsupported signature: %S" func)))))
Currently the func-arity call fails when the function is adviced. This
is a nice format to follow since it
1. allows reuse of existing functions to be executed as actions
without the need for wrapper functions
[ i.e., (lambda (str) (xref-find-definitions str)) ]
2. allows the "action" function to specify what it ends by changing
its required arguments.
I hope this is clear.
>> (func-arity (advice--cd*r (indirect-function 'xref-find-definitions))) ;; ⇒ (1 . 1)
>>
>> which is the right return value. It might be nice to not have to call
>> `indirect-function' here for the "global" function but you can be a
>> better judge of that.
>
> Don't know what you mean by "global" function.
By "global", I mean the new global function advice-cd*r or somesuch that
might eventually be added from this discussion.
> Side note: an advice may also be installed specifically to change the
> arity, e.g. to add support for some new calling convention.
Ahhhhhh... now we have a complication that I never thought about.
>> In our case, the functions that will be checked for its arity should be
>> defined at the time of func-arity call. Or at least auto-loaded AFAIU.
>
> By "autoloaded" do you mean "setup to be loaded on demand but not yet
> loaded", or do you mean "had been setup to be loaded on demand and has
> been loaded already"?
The former obviously.
> The second case is "irrelevant" in the sense that it doesn't matter if
> the function had been autoloaded before it was defined.
>
>
> Stefan
next prev parent reply other threads:[~2023-11-04 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 8:34 bug#66908: Exposing more public nadvice API Philip Kaludercic
2023-11-03 16:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-03 18:50 ` Visuwesh
2023-11-03 19:24 ` Drew Adams
2023-11-03 22:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 2:48 ` Visuwesh
2023-11-04 6:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 6:28 ` Visuwesh [this message]
2023-11-04 8:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 9:58 ` Philip Kaludercic
2023-11-04 15:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmuydobs.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=66908@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).