unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Kenichi Handa <handa@m17n.org>
Cc: 4209@debbugs.gnu.org, cyd@stupidchicken.com
Subject: bug#4209: 23.1; Emacs 23.1 regression in re-search-forward
Date: Thu, 28 Jan 2010 14:01:55 -0500	[thread overview]
Message-ID: <jwvvdemoy0b.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <tl7636nvxfk.fsf@m17n.org> (Kenichi Handa's message of "Thu, 28 Jan 2010 10:18:55 +0900")

> So, in emacs-unicode branch, I fixed the regex code so that
> unibyte pattern can be directry used for multibyte buffer
> search by doing unibyte->multibyte conversion on the fly.
> And that code was merged to trunk.

Hmm... that's too bad since the subsequent change to get rid of the
dependency on locales made this change unnecessary.

But given this, yes, the patch looks right, and no, I have no idea what
the CHAR_BYTE8_P test was trying to do.


        Stefan






  reply	other threads:[~2010-01-28 19:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-20  0:50 bug#4209: 23.1; Emacs 23.1 regression in re-search-forward Christopher J. Madsen
2010-01-26 20:38 ` Chong Yidong
2010-01-27  3:43   ` Kenichi Handa
2010-01-27  5:41     ` Kenichi Handa
2010-01-27 14:34       ` Stefan Monnier
2010-01-27 16:43         ` Chong Yidong
2010-01-28  1:18         ` Kenichi Handa
2010-01-28 19:01           ` Stefan Monnier [this message]
2010-01-29  6:15             ` Kenichi Handa
  -- strict thread matches above, loose matches on Subject: below --
2009-12-02  0:21 Matthew Dempsky
2009-12-07  3:30 Christopher J. Madsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvdemoy0b.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=4209@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).