unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthew Dempsky <matthew@dempsky.org>
To: 4209@emacsbugs.donarmstrong.com
Subject: bug#4209: 23.1; Emacs 23.1 regression in re-search-forward
Date: Tue, 1 Dec 2009 16:21:07 -0800	[thread overview]
Message-ID: <d791b8790912011621i481383e5pd8976c7a4d897633@mail.gmail.com> (raw)

This is a stab in the dark, but the patch below corrects this issue for me:

    $ ./retest.sh
    looking-at: t
    re-search-forward: 9

I don't see any reason this should cause regressions (searching
forward 0 steps seems to me it should be the same as searching
backward 0 steps), but I've only casually looked over regex.c.

--- a/src/regex.c
+++ b/src/regex.c
@@ -4524,7 +4524,7 @@ re_search_2 (bufp, str1, size1, str2, size2,
startpos, range, regs, stop)

          d = POS_ADDR_VSTRING (startpos);

-         if (range > 0)        /* Searching forwards.  */
+         if (range >= 0)       /* Searching forwards.  */
            {
              register int lim = 0;
              int irange = range;





             reply	other threads:[~2009-12-02  0:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  0:21 Matthew Dempsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-12-07  3:30 bug#4209: 23.1; Emacs 23.1 regression in re-search-forward Christopher J. Madsen
2009-08-20  0:50 Christopher J. Madsen
2010-01-26 20:38 ` Chong Yidong
2010-01-27  3:43   ` Kenichi Handa
2010-01-27  5:41     ` Kenichi Handa
2010-01-27 14:34       ` Stefan Monnier
2010-01-27 16:43         ` Chong Yidong
2010-01-28  1:18         ` Kenichi Handa
2010-01-28 19:01           ` Stefan Monnier
2010-01-29  6:15             ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d791b8790912011621i481383e5pd8976c7a4d897633@mail.gmail.com \
    --to=matthew@dempsky.org \
    --cc=4209@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).