From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 14403@debbugs.gnu.org
Subject: bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session
Date: Wed, 22 May 2013 12:06:47 -0400 [thread overview]
Message-ID: <jwvvc6bj96y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83sj1o64q8.fsf@gnu.org>
> Of course, we could always augment this condition:
> if (!((FRAME_TERMCAP_P (frame) || FRAME_MSDOS_P (frame))
> && (TERMINAL_KEYBOARD_CODING (terminal)->common_flags
> & CODING_REQUIRE_DECODING_MASK)))
> return nextevt; /* No decoding needed. */
Before my change, the test was just
(TERMINAL_KEYBOARD_CODING (terminal)->common_flags
& CODING_REQUIRE_DECODING_MASK)
but was done inside tty_read_avail_input. AFAICT, tty_read_avail_input
is only used under POSIX ttys and MSDOS, hence this bug: FRAME_TERMCAP_P
is true for w32 non-GUI frames even though they don't use
tty_read_avail_input (they use w32_console_read_socket instead).
So a crude fix would be to check
"terminal->read_socket_hook == &tty_read_avail_input".
What would be a good test to cleanly distinguish posix ttys from w32
"ttys"?
Stefan
next prev parent reply other threads:[~2013-05-22 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 19:11 bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session dmoncayo
2013-05-14 19:48 ` Eli Zaretskii
2013-05-14 22:28 ` Stefan Monnier
2013-05-15 8:13 ` Eli Zaretskii
2013-05-22 16:06 ` Stefan Monnier [this message]
2013-05-22 20:39 ` Eli Zaretskii
2013-05-22 21:22 ` Stefan Monnier
2013-05-23 2:46 ` Eli Zaretskii
2013-05-23 14:02 ` Stefan Monnier
2013-05-23 16:23 ` Eli Zaretskii
2013-05-23 17:22 ` Dani Moncayo
2013-05-23 17:38 ` Juanma Barranquero
2013-05-22 20:22 ` Juanma Barranquero
2013-05-22 20:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvc6bj96y.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14403@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).