From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session Date: Wed, 22 May 2013 12:06:47 -0400 Message-ID: References: <87ppwt2x7p.fsf@gmail.com> <83hai5736q.fsf@gnu.org> <83sj1o64q8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1369238851 6623 80.91.229.3 (22 May 2013 16:07:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 May 2013 16:07:31 +0000 (UTC) Cc: 14403@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 18:07:30 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UfBZZ-0000Si-AZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2013 18:07:29 +0200 Original-Received: from localhost ([::1]:37877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfBZY-0001aC-S3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2013 12:07:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfBZR-0001YC-V5 for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 12:07:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfBZN-00048s-C3 for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 12:07:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfBZN-00048l-8z for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 12:07:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UfBa5-0001G1-II for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 12:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2013 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14403-submit@debbugs.gnu.org id=B14403.13692388604794 (code B ref 14403); Wed, 22 May 2013 16:08:01 +0000 Original-Received: (at 14403) by debbugs.gnu.org; 22 May 2013 16:07:40 +0000 Original-Received: from localhost ([127.0.0.1]:56474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UfBZj-0001FG-IO for submit@debbugs.gnu.org; Wed, 22 May 2013 12:07:40 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:59194) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UfBZi-0001FA-5H for 14403@debbugs.gnu.org; Wed, 22 May 2013 12:07:38 -0400 Original-Received: from ceviche.home ([184.163.196.74]) by VL-VM-MR001.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MN7006ZTJFBXH40@VL-VM-MR001.ip.videotron.ca> for 14403@debbugs.gnu.org; Wed, 22 May 2013 12:06:47 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 45DD966107; Wed, 22 May 2013 12:06:47 -0400 (EDT) In-reply-to: <83sj1o64q8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74452 Archived-At: > Of course, we could always augment this condition: > if (!((FRAME_TERMCAP_P (frame) || FRAME_MSDOS_P (frame)) > && (TERMINAL_KEYBOARD_CODING (terminal)->common_flags > & CODING_REQUIRE_DECODING_MASK))) > return nextevt; /* No decoding needed. */ Before my change, the test was just (TERMINAL_KEYBOARD_CODING (terminal)->common_flags & CODING_REQUIRE_DECODING_MASK) but was done inside tty_read_avail_input. AFAICT, tty_read_avail_input is only used under POSIX ttys and MSDOS, hence this bug: FRAME_TERMCAP_P is true for w32 non-GUI frames even though they don't use tty_read_avail_input (they use w32_console_read_socket instead). So a crude fix would be to check "terminal->read_socket_hook == &tty_read_avail_input". What would be a good test to cleanly distinguish posix ttys from w32 "ttys"? Stefan