* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
@ 2014-05-30 13:19 Le Wang
2014-05-30 19:55 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Le Wang @ 2014-05-30 13:19 UTC (permalink / raw)
To: 17642
I've seen this bug:
http://emacs.1067599.n5.nabble.com/bug-17168-24-3-50-Segfault-at-mark-object-td319032.html
I'm not sure if it's related to what I'm seeing. If I remove all
`clear-transient-map' from my pre-command-hook, they come back in
quick order.
--
Le
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
2014-05-30 13:19 bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1 Le Wang
@ 2014-05-30 19:55 ` Stefan Monnier
2014-05-30 21:52 ` Thierry Volpiatto
2014-06-01 2:35 ` Le Wang
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2014-05-30 19:55 UTC (permalink / raw)
To: Le Wang; +Cc: 17642
> I'm not sure if it's related to what I'm seeing. If I remove all
> `clear-transient-map' from my pre-command-hook, they come back in
> quick order.
That's weird. Do you see any strange message in *Messages*?
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
2014-05-30 19:55 ` Stefan Monnier
@ 2014-05-30 21:52 ` Thierry Volpiatto
2014-05-31 1:36 ` Stefan Monnier
2014-06-01 2:35 ` Le Wang
1 sibling, 1 reply; 6+ messages in thread
From: Thierry Volpiatto @ 2014-05-30 21:52 UTC (permalink / raw)
To: 17642
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I'm not sure if it's related to what I'm seeing. If I remove all
>> `clear-transient-map' from my pre-command-hook, they come back in
>> quick order.
>
> That's weird. Do you see any strange message in *Messages*?
Helm is using `set-transient-map' a lot and it seems `set-transient-map'
doesn't remove properly its `clearfun' from `pre-command-hook' or more
exactly the `clearfun' doesn't remove itself from `pre-command-hook'.
So the many entries found in `pre-command-hook' may come from this.
BTW `set-transient-map' description in info is not accorded to its
docstring.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
2014-05-30 21:52 ` Thierry Volpiatto
@ 2014-05-31 1:36 ` Stefan Monnier
[not found] ` <87egza34kw.fsf@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2014-05-31 1:36 UTC (permalink / raw)
To: Thierry Volpiatto; +Cc: 17642
> Helm is using `set-transient-map' a lot and it seems `set-transient-map'
> doesn't remove properly its `clearfun' from `pre-command-hook' or more
> exactly the `clearfun' doesn't remove itself from `pre-command-hook'.
Clearly, that's what we see, but the question is "why". The code does do
(remove-hook 'pre-command-hook clearfun)
so why is this code not run?
Maybe it's because of the new condition:
((not (eq map (cadr overriding-terminal-local-map)))
;; There's presumably some other transient-map in
;; effect. Wait for that one to terminate before we
;; remove ourselves.
;; For example, if isearch and C-u both use transient
;; maps, then the lifetime of the C-u should be nested
;; within isearch's, so the pre-command-hook of
;; isearch should be suspended during the C-u one so
;; we don't exit isearch just because we hit 1 after
;; C-u and that 1 exits isearch whereas it doesn't
;; exit C-u.
t)
IOW, could it be that Helm keeps adding new transient-maps, rather than
follow the usual "nesting" of transient maps?
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
[not found] ` <871tv9orbu.fsf@gmail.com>
@ 2014-05-31 20:04 ` Stefan Monnier
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2014-05-31 20:04 UTC (permalink / raw)
To: Thierry Volpiatto; +Cc: 17642-done
[ I see you dropped 17642@debbugs.gnu.org from the Cc, please try not
to do that, so the debugging gets recorded in the bug-tracker. ]
>> Could you remove this workaround and try the patch below instead?
> Done, seems to work fine.
Great, thanks, installed,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
2014-05-30 19:55 ` Stefan Monnier
2014-05-30 21:52 ` Thierry Volpiatto
@ 2014-06-01 2:35 ` Le Wang
1 sibling, 0 replies; 6+ messages in thread
From: Le Wang @ 2014-06-01 2:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 17642
Patch Stefan installed fixes the problem for me.
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-24&id=d8a8adcdff43078b28ba68da6578a6c65d991ab7
Thanks all.
On Fri, May 30, 2014 at 3:55 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> I'm not sure if it's related to what I'm seeing. If I remove all
>> `clear-transient-map' from my pre-command-hook, they come back in
>> quick order.
>
> That's weird. Do you see any strange message in *Messages*?
>
>
> Stefan
--
Le
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-01 2:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-30 13:19 bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1 Le Wang
2014-05-30 19:55 ` Stefan Monnier
2014-05-30 21:52 ` Thierry Volpiatto
2014-05-31 1:36 ` Stefan Monnier
[not found] ` <87egza34kw.fsf@gmail.com>
[not found] ` <jwvoaye9fdu.fsf-monnier+emacsbugs@gnu.org>
[not found] ` <871tv9orbu.fsf@gmail.com>
2014-05-31 20:04 ` Stefan Monnier
2014-06-01 2:35 ` Le Wang
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).