From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Gustav Hållberg" <gustav@gmail.com>
Cc: 20276-done@debbugs.gnu.org
Subject: bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs
Date: Wed, 08 Apr 2015 21:48:49 -0400 [thread overview]
Message-ID: <jwvvbh6ozat.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAFBaKAy4xvNf0W=e8CG0qLbrfUEm_uyHonJfjH6NcpPZDi5aqw@mail.gmail.com> ("Gustav Hållberg"'s message of "Thu, 9 Apr 2015 00:38:55 +0200")
> git diff also does for what it's worth.
Ah, indeed. This doesn't bite us too hard because git also happens to
provide the "diff ..." line.
> True, but note that diff-font-lock-keywords is more permissive; it does not
> require the tab to be present.
Of course a false positive in diff-font-lock-keywords will only look
funny but won't affect actual behavior, which is why I thought it was OK
to be more permissive.
Anyway, I guess we have to bite this bullet, so I installed your patch
into "master". Thanks,
Stefan
prev parent reply other threads:[~2015-04-09 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 22:34 bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs Gustav Hållberg
2015-04-08 20:50 ` Stefan Monnier
2015-04-08 22:38 ` Gustav Hållberg
2015-04-09 1:48 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbh6ozat.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20276-done@debbugs.gnu.org \
--cc=gustav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).