From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Gustav Hållberg" <gustav@gmail.com>
Cc: 20276@debbugs.gnu.org
Subject: bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs
Date: Wed, 08 Apr 2015 16:50:06 -0400 [thread overview]
Message-ID: <jwvpp7eny7h.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAFBaKAyejgkrzqRD+-oQaXug=StkO8uUt5w_LfoRQpkFaZQNbA@mail.gmail.com> ("Gustav Hållberg"'s message of "Wed, 8 Apr 2015 00:34:23 +0200")
> Some diff programs will not emit tab + timestamp (as GNU diff does),
> but just the file name.
Which diff programs do that?
> - (if (looking-at "[-*][-*][-*] \\([^\t]+\\)\t.*\n[-+][-+][-+]
> \\([^\t]+\\)")
> + (if (looking-at "[-*][-*][-*] \\([^\t\n]+\\).*\n[-+][-+][-+]
> \\([^\t\n]+\\)")
Adding \n in the char-ranges is fine (it's a good change in itself), but
removing the \t increases the risk of false positives, so I'm a bit
worried about that.
Stefan
next prev parent reply other threads:[~2015-04-08 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 22:34 bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs Gustav Hållberg
2015-04-08 20:50 ` Stefan Monnier [this message]
2015-04-08 22:38 ` Gustav Hållberg
2015-04-09 1:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpp7eny7h.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20276@debbugs.gnu.org \
--cc=gustav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).