unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13156: dedicated face for parentheses in lisp modes
@ 2012-12-12 12:19 Jonas Bernoulli
  2012-12-18 15:32 ` Stefan Monnier
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Jonas Bernoulli @ 2012-12-12 12:19 UTC (permalink / raw)
  To: 13156

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Hello

Could you please add a `paren-face' that could be used in lisp modes
(and possibly others) to dim (or highlight) parentheses.  I am currently
using the attached library to do this but think it would make sense if
this functionality was built-in.

Being very simple `parenface.el' just unconditionally adds an additional
keyword to `[lisp|scheme]-font-lock-keywords' when loaded.

I see two ways of implementing this as part of Emacs.

1. Add the keyword to `[lisp|scheme]-font-lock-keywords-2' directly and
   let `paren-face' inherit from `default'.  Users who actually want
   parens to be dimmed or highlight can then customize the former.

2. Define a local minor mode that adds the additional keywords.

I would prefer (1) but maybe that is not an option because it might
negatively affects font-lock's performance.

If this has to be a mode then I am happy to write it.  I haven't done
so yet because `parenface.el' works fine for me and because I would
actually prefer (1).

  Thanks for considering,
  Jonas


[-- Attachment #2: parenface.el --]
[-- Type: application/emacs-lisp, Size: 1403 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-12 12:19 bug#13156: dedicated face for parentheses in lisp modes Jonas Bernoulli
@ 2012-12-18 15:32 ` Stefan Monnier
  2012-12-19 15:46   ` Jonas Bernoulli
  2012-12-19 16:20 ` Michael Heerdegen
  2019-08-12  1:05 ` Stefan Kangas
  2 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2012-12-18 15:32 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: 13156

> Could you please add a `paren-face' that could be used in lisp modes
> (and possibly others) to dim (or highlight) parentheses.  I am currently
> using the attached library to do this but think it would make sense if
> this functionality was built-in.

I don't think it's sufficiently useful in general.

> Being very simple `parenface.el' just unconditionally adds an additional
> keyword to `[lisp|scheme]-font-lock-keywords' when loaded.

It could use font-lock-add-keywords.

BTW, if all parens are displayed the same, then you can also use the
buffer-display-table.

> If this has to be a mode then I am happy to write it.  I haven't done
> so yet because `parenface.el' works fine for me and because I would
> actually prefer (1).

Having it as a separate mode would make more sense, yes.


        Stefan





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-18 15:32 ` Stefan Monnier
@ 2012-12-19 15:46   ` Jonas Bernoulli
  0 siblings, 0 replies; 12+ messages in thread
From: Jonas Bernoulli @ 2012-12-19 15:46 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13156


Stefan Monnier writes:

>> Could you please add a `paren-face' that could be used in lisp modes
>> (and possibly others) to dim (or highlight) parentheses.  I am currently
>> using the attached library to do this but think it would make sense if
>> this functionality was built-in.
>
> I don't think it's sufficiently useful in general.

What about all the Emacs users that are scared of lisp "because of all
the parens"?  Dimming them might reduce the shock :-)

>> Being very simple `parenface.el' just unconditionally adds an additional
>> keyword to `[lisp|scheme]-font-lock-keywords' when loaded.
>
> It could use font-lock-add-keywords.

That's what I was going to do.

> BTW, if all parens are displayed the same, then you can also use the
> buffer-display-table.

Since you are suggesting this I assume that doesn't mess with
highlighting with highlighting matching parens.  So I will try that too.

>> If this has to be a mode then I am happy to write it.  I haven't done
>> so yet because `parenface.el' works fine for me and because I would
>> actually prefer (1).
>
> Having it as a separate mode would make more sense, yes.

If you don't change your mind about this not being sufficiently useful
to be built-in, then I will do write a mode; eventually.

  Jonas





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-12 12:19 bug#13156: dedicated face for parentheses in lisp modes Jonas Bernoulli
  2012-12-18 15:32 ` Stefan Monnier
@ 2012-12-19 16:20 ` Michael Heerdegen
  2012-12-19 18:27   ` Stefan Monnier
  2019-08-12  1:05 ` Stefan Kangas
  2 siblings, 1 reply; 12+ messages in thread
From: Michael Heerdegen @ 2012-12-19 16:20 UTC (permalink / raw)
  To: 13156

Hi,

just for completeness do I want to mention "RainbowDelimiters" here:

  http://www.emacswiki.org/emacs/RainbowDelimiters

It is a generalization of what you want.  It is also suitable of
reducing deterrence of Lisp, and it helps reading LISP code a lot,
without losing anything.

If anything like that should be built-in, then I would vote for that
package.


Regards,

Michael.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-19 16:20 ` Michael Heerdegen
@ 2012-12-19 18:27   ` Stefan Monnier
  2012-12-21 14:29     ` Michael Heerdegen
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2012-12-19 18:27 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: 13156

> just for completeness do I want to mention "RainbowDelimiters" here:

I'd be happy to see this package in GNU ELPA.  If someone could take
care of tracking down the copyright assignments...


        Stefan





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-19 18:27   ` Stefan Monnier
@ 2012-12-21 14:29     ` Michael Heerdegen
  2012-12-22 15:58       ` Stefan Monnier
  0 siblings, 1 reply; 12+ messages in thread
From: Michael Heerdegen @ 2012-12-21 14:29 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13156

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > just for completeness do I want to mention "RainbowDelimiters" here:
>
> I'd be happy to see this package in GNU ELPA.  If someone could take
> care of tracking down the copyright assignments...

Does he just have to sign the copyright papers (normal procedure), or is
something special needed for Elpa?  If the first is true, I volunteer to
contact the author.


Regards,

Michael.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-21 14:29     ` Michael Heerdegen
@ 2012-12-22 15:58       ` Stefan Monnier
  2012-12-24 13:45         ` Michael Heerdegen
                           ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Stefan Monnier @ 2012-12-22 15:58 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: 13156

> Does he just have to sign the copyright papers (normal procedure), or is
> something special needed for Elpa?

From a copyright point of view, we treat GNU ELPA as being part of
Emacs, so it's the exact same paperwork (where the project name is
"Emacs").  This is so that we can easily move code between Emacs and
GNU ELPA.

> If the first is true, I volunteer to contact the author.

Thank you,


        Stefan





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-22 15:58       ` Stefan Monnier
@ 2012-12-24 13:45         ` Michael Heerdegen
  2013-01-18  2:23         ` Michael Heerdegen
  2013-10-15 18:29         ` Michael Heerdegen
  2 siblings, 0 replies; 12+ messages in thread
From: Michael Heerdegen @ 2012-12-24 13:45 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13156

> > I volunteer to contact the author.

Done.  I'll tell you when I got an answer.

Michael.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-22 15:58       ` Stefan Monnier
  2012-12-24 13:45         ` Michael Heerdegen
@ 2013-01-18  2:23         ` Michael Heerdegen
  2013-10-15 18:29         ` Michael Heerdegen
  2 siblings, 0 replies; 12+ messages in thread
From: Michael Heerdegen @ 2013-01-18  2:23 UTC (permalink / raw)
  To: 13156

> > If the first is true, I volunteer to contact the author.

I wrote a message to the address given in the file header, but did not
receive any answer until now, sorry.  No idea how to contact him
otherwise.


Michael.






^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-22 15:58       ` Stefan Monnier
  2012-12-24 13:45         ` Michael Heerdegen
  2013-01-18  2:23         ` Michael Heerdegen
@ 2013-10-15 18:29         ` Michael Heerdegen
  2014-08-27 22:46           ` Michael Heerdegen
  2 siblings, 1 reply; 12+ messages in thread
From: Michael Heerdegen @ 2013-10-15 18:29 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13156, opensource

Hello,

> > Does he just have to sign the copyright papers (normal procedure), or is
> > something special needed for Elpa?
>
> From a copyright point of view, we treat GNU ELPA as being part of
> Emacs, so it's the exact same paperwork (where the project name is
> "Emacs").  This is so that we can easily move code between Emacs and
> GNU ELPA.
>
> > If the first is true, I volunteer to contact the author.

Great news!  I've now contact with the author, and he is willing to sign
the papers.  We will tell you when it's done.


Regards,

Michael.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2013-10-15 18:29         ` Michael Heerdegen
@ 2014-08-27 22:46           ` Michael Heerdegen
  0 siblings, 0 replies; 12+ messages in thread
From: Michael Heerdegen @ 2014-08-27 22:46 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13156, opensource

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Great news!  I've now contact with the author, and he is willing to sign
> the papers.  We will tell you when it's done.

I'm very sorry, but he told me now that he wont sign the papers.

Michael.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#13156: dedicated face for parentheses in lisp modes
  2012-12-12 12:19 bug#13156: dedicated face for parentheses in lisp modes Jonas Bernoulli
  2012-12-18 15:32 ` Stefan Monnier
  2012-12-19 16:20 ` Michael Heerdegen
@ 2019-08-12  1:05 ` Stefan Kangas
  2 siblings, 0 replies; 12+ messages in thread
From: Stefan Kangas @ 2019-08-12  1:05 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Jonas Bernoulli, 13156-done

tags 13156 + wontfix
thanks

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Could you please add a `paren-face' that could be used in lisp modes
>> (and possibly others) to dim (or highlight) parentheses.  I am currently
>> using the attached library to do this but think it would make sense if
>> this functionality was built-in.
>
> I don't think it's sufficiently useful in general.

Since this was rejected in 2012, I'm closing it as wontfix.

If anyone disagrees with that, feel free to reopen.

Thanks,
Stefan Kangas





^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-08-12  1:05 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-12 12:19 bug#13156: dedicated face for parentheses in lisp modes Jonas Bernoulli
2012-12-18 15:32 ` Stefan Monnier
2012-12-19 15:46   ` Jonas Bernoulli
2012-12-19 16:20 ` Michael Heerdegen
2012-12-19 18:27   ` Stefan Monnier
2012-12-21 14:29     ` Michael Heerdegen
2012-12-22 15:58       ` Stefan Monnier
2012-12-24 13:45         ` Michael Heerdegen
2013-01-18  2:23         ` Michael Heerdegen
2013-10-15 18:29         ` Michael Heerdegen
2014-08-27 22:46           ` Michael Heerdegen
2019-08-12  1:05 ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).