From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefankangas@gmail.com>, 59923@debbugs.gnu.org
Subject: bug#59923: Error when installing non-existent package add trailing dash character to package name
Date: Sun, 11 Dec 2022 09:28:50 -0500 [thread overview]
Message-ID: <jwvtu22m2ux.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <837cyyutcg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Dec 2022 12:29:03 +0200")
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index a9fd8c741e..4d33311cb7 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -1949,8 +1949,10 @@ package-compute-transaction
>> (if (eq next-pkg 'emacs)
>> (error "This package requires Emacs version %s"
>> (package-version-join next-version))
>> - (error "Package `%s-%s' is unavailable"
>> - next-pkg (package-version-join next-version))))))
>> + (error (if (not next-version)
>> + (format "Package `%s' is unavailable" next-pkg)
>> + (format "Package `%s' (version %s) is unavailable"
>> + next-pkg (package-version-join
>> next-version))))))))
>> (setq packages
>> (package-compute-transaction (cons found packages)
>> (package-desc-reqs found)
>>
LGTM (modulo the wrapping introduced by email quoting, obviously :-)
Stefan
next prev parent reply other threads:[~2022-12-11 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 10:57 bug#59923: Error when installing non-existent package add trailing dash character to package name Stefan Kangas
2022-12-11 10:29 ` Eli Zaretskii
2022-12-11 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-12-11 18:03 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtu22m2ux.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=59923@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).