From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59923: Error when installing non-existent package add trailing dash character to package name Date: Sun, 11 Dec 2022 09:28:50 -0500 Message-ID: References: <837cyyutcg.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas , 59923@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 15:29:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4NKN-0006a5-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 15:29:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4NKC-0002KN-DR; Sun, 11 Dec 2022 09:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4NKA-0002KF-PU for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 09:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4NKA-0006br-Hb for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 09:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4NKA-0004yb-B4 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 09:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59923-submit@debbugs.gnu.org id=B59923.167076894119122 (code B ref 59923); Sun, 11 Dec 2022 14:29:02 +0000 Original-Received: (at 59923) by debbugs.gnu.org; 11 Dec 2022 14:29:01 +0000 Original-Received: from localhost ([127.0.0.1]:46458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4NK8-0004yM-LU for submit@debbugs.gnu.org; Sun, 11 Dec 2022 09:29:01 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4NK7-0004yG-64 for 59923@debbugs.gnu.org; Sun, 11 Dec 2022 09:28:59 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A5F641000FC; Sun, 11 Dec 2022 09:28:53 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6164D1000D2; Sun, 11 Dec 2022 09:28:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670768932; bh=+Scnub+U18PQW1D0I5t2NFISmT2tE5BVTlDWE9Pj1FI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Sr7La81Q+eDohic1nVtG+GOhPaNp99yQyqWPrg/T49/Es4vUteXazH5uxelLO2N01 3WfFWnu24oBSNXDn9FaE35W4zi/AgxaV4zurMXRytuXlub3Im84mQRAJHH6oOyf73V Q3eqNcfajwj1yD/f77RDvf5u77dhEwLB3WZhB71cBpGhI9Vdcly+PPs4KU4Y2HUIaz bB4hy2bdL9LpZe12ufe90mdQVrRBjpGyRPHsB6V/60Vmu6hdw91nSFG7zk5LK7/bmg gVWFZGZmc9tGHArDQEjm2Ui/SV83KNTHPfWCXgwTxm6CXbTxUUpz15JeGEr0Uh+Cm8 aQNnrgbUCd5lA== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 313A7122631; Sun, 11 Dec 2022 09:28:52 -0500 (EST) In-Reply-To: <837cyyutcg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Dec 2022 12:29:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250608 Archived-At: >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index a9fd8c741e..4d33311cb7 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -1949,8 +1949,10 @@ package-compute-transaction >> (if (eq next-pkg 'emacs) >> (error "This package requires Emacs version %s" >> (package-version-join next-version)) >> - (error "Package `%s-%s' is unavailable" >> - next-pkg (package-version-join next-version)))))) >> + (error (if (not next-version) >> + (format "Package `%s' is unavailable" next-pkg) >> + (format "Package `%s' (version %s) is unavailable" >> + next-pkg (package-version-join >> next-version)))))))) >> (setq packages >> (package-compute-transaction (cons found packages) >> (package-desc-reqs found) >> LGTM (modulo the wrapping introduced by email quoting, obviously :-) Stefan