* bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
@ 2013-01-07 20:50 Kim F. Storm
[not found] ` <handler.13380.B.13575918662641.ack@debbugs.gnu.org>
2013-01-08 17:36 ` bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection Stefan Monnier
0 siblings, 2 replies; 5+ messages in thread
From: Kim F. Storm @ 2013-01-07 20:50 UTC (permalink / raw)
To: 13380
The following change is just SO annoying.
I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the files that need attention -- but with this change,
it is practically random what is kept and what is removed.
2012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
* vc/pcvs.el (cvs-cleanup-collection): Keep entries that are currently
visited in a buffer.
Could we at least have it as an option, -- thank you.
In GNU Emacs 24.2.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
of 2013-01-02 on kfs-lx2
Windowing system distributor `The X.Org Foundation', version 11.0.11104000
System Description: Debian GNU/Linux 6.0.6 (squeeze)
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13380: Acknowledgement (24.2.91; Annoying change to cvs-cleanup-collection)
[not found] ` <handler.13380.B.13575918662641.ack@debbugs.gnu.org>
@ 2013-01-07 20:59 ` Kim Storm
0 siblings, 0 replies; 5+ messages in thread
From: Kim Storm @ 2013-01-07 20:59 UTC (permalink / raw)
To: 13380
Of course, what I meant was
I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the entries that _DON'T_ need attention -- but with this change,
it is practically random what is kept and what is removed.
Kim
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
2013-01-07 20:50 bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection Kim F. Storm
[not found] ` <handler.13380.B.13575918662641.ack@debbugs.gnu.org>
@ 2013-01-08 17:36 ` Stefan Monnier
2013-01-08 18:35 ` Kim Storm
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2013-01-08 17:36 UTC (permalink / raw)
To: Kim F. Storm; +Cc: 13380
> The following change is just SO annoying.
> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
> all the files that need attention -- but with this change,
> it is practically random what is kept and what is removed.
Oh, it was not meant to affect `x', indeed. I just installed the patch
below which should fix it.
Stefan
=== modified file 'lisp/vc/pcvs.el'
--- lisp/vc/pcvs.el 2013-01-01 09:11:05 +0000
+++ lisp/vc/pcvs.el 2013-01-08 17:29:57 +0000
@@ -876,9 +876,10 @@
(`DEAD nil)
;; handled also?
(`UP-TO-DATE
+ (not
(if (find-buffer-visiting (cvs-fileinfo->full-name fi))
- t
- (not rm-handled)))
+ (eq rm-handled 'all)
+ rm-handled)))
;; keep the rest
(_ (not (run-hook-with-args-until-success
'cvs-cleanup-functions fi))))))
@@ -2121,7 +2122,7 @@
Empty directories are removed."
(interactive)
(cvs-cleanup-collection cvs-cookies
- t (or cvs-auto-remove-directories 'handled) t))
+ 'all (or cvs-auto-remove-directories 'handled) t))
(defun-cvs-mode cvs-mode-acknowledge ()
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
2013-01-08 17:36 ` bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection Stefan Monnier
@ 2013-01-08 18:35 ` Kim Storm
2013-01-08 21:07 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Kim Storm @ 2013-01-08 18:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 13380
On 2013-01-08 18:36, Stefan Monnier wrote:
>> The following change is just SO annoying.
>> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
>> all the files that need attention -- but with this change,
>> it is practically random what is kept and what is removed.
> Oh, it was not meant to affect `x', indeed. I just installed the patch
> below which should fix it.
>
Yes, that fixes it.
Thank you
Kim
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
2013-01-08 18:35 ` Kim Storm
@ 2013-01-08 21:07 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2013-01-08 21:07 UTC (permalink / raw)
To: Kim Storm; +Cc: 13380-done
> Yes, that fixes it.
> Thank you
Great, thanks, closing,
Stefan "we're missing you here"
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-08 21:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07 20:50 bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection Kim F. Storm
[not found] ` <handler.13380.B.13575918662641.ack@debbugs.gnu.org>
2013-01-07 20:59 ` bug#13380: Acknowledgement (24.2.91; Annoying change to cvs-cleanup-collection) Kim Storm
2013-01-08 17:36 ` bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection Stefan Monnier
2013-01-08 18:35 ` Kim Storm
2013-01-08 21:07 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).