From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Drew Adams <drew.adams@oracle.com>
Cc: 14734-done@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Thu, 27 Jun 2013 14:15:22 -0400 [thread overview]
Message-ID: <jwvsj034e5b.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <c72999d0-4210-4719-934d-e9e06f522f70@default> (Drew Adams's message of "Thu, 27 Jun 2013 10:08:41 -0700 (PDT)")
tags 14734 wontfix
thanks
> :around advice: `ad-Advice-isearch-forward'
[...]
> It is also incorrect. The advice is :before, not :around.
It is correct: the ad-Advice-isearch-forward advice is an around advice
(and it is not your advice, it's internal as you say).
If you click on it, you'll see your before advice, properly labeled.
If you don't want to see the internal thingy, then use the new
advice-add rather than the old defadvice.
Stefan
next prev parent reply other threads:[~2013-06-27 18:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 17:08 bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Drew Adams
2013-06-27 18:15 ` Stefan Monnier [this message]
2013-06-27 18:40 ` Drew Adams
2013-06-28 17:39 ` Drew Adams
2013-06-28 20:44 ` Dmitry Gutov
2013-06-28 21:56 ` Drew Adams
2013-06-28 22:19 ` Michael Heerdegen
2019-09-23 21:07 ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27 ` Michael Heerdegen
2013-06-28 23:21 ` Stefan Monnier
2013-06-29 1:37 ` Drew Adams
2013-06-29 2:09 ` Stefan Monnier
2013-06-29 2:28 ` Drew Adams
2013-06-29 3:24 ` Stefan Monnier
2013-06-29 20:29 ` Juanma Barranquero
2013-06-30 1:39 ` Stefan Monnier
2013-07-05 14:50 ` Drew Adams
2013-07-05 14:57 ` Juanma Barranquero
2013-07-05 22:44 ` Stefan Monnier
2013-07-06 1:40 ` Drew Adams
2013-07-06 9:18 ` Stefan Monnier
2013-07-06 20:22 ` Drew Adams
2013-10-20 23:27 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsj034e5b.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14734-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).