unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Drew Adams <drew.adams@oracle.com>
Cc: 14734@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Sat, 29 Jun 2013 00:44:29 +0400	[thread overview]
Message-ID: <87a9mat176.fsf@yandex.ru> (raw)
In-Reply-To: <c6e75742-6033-40ff-8fd4-79e190eefa8b@default> (Drew Adams's message of "Fri, 28 Jun 2013 10:39:54 -0700 (PDT)")

(Not Stefan.)

Drew Adams <drew.adams@oracle.com> writes:

> The change introduced is horrible for users.  Now they see only
> the original doc string, plus a link that will be incomprehensible
> to many (so skipped over by them):

You're overdramatizing. It's less convenient, but far from "horrible".

> Not only can Emacs do better, it always HAS.  This is a real step
> backward for users.  Intentional or not.  I'm reopening the bug.
> I hope you will seriously consider reverting the misguided changes
> that introduced this regression.

It's obviously the result of advice.el being re-implemented using
nadvice.el, for backward compatibility. Having a minor regression in
functionality in this kind of situation is fairly normal.





  reply	other threads:[~2013-06-28 20:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 17:08 bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Drew Adams
2013-06-27 18:15 ` Stefan Monnier
2013-06-27 18:40   ` Drew Adams
2013-06-28 17:39     ` Drew Adams
2013-06-28 20:44       ` Dmitry Gutov [this message]
2013-06-28 21:56         ` Drew Adams
2013-06-28 22:19           ` Michael Heerdegen
2019-09-23 21:07         ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27   ` Michael Heerdegen
2013-06-28 23:21     ` Stefan Monnier
2013-06-29  1:37       ` Drew Adams
2013-06-29  2:09         ` Stefan Monnier
2013-06-29  2:28           ` Drew Adams
2013-06-29  3:24             ` Stefan Monnier
2013-06-29 20:29               ` Juanma Barranquero
2013-06-30  1:39                 ` Stefan Monnier
2013-07-05 14:50                   ` Drew Adams
2013-07-05 14:57                     ` Juanma Barranquero
2013-07-05 22:44                     ` Stefan Monnier
2013-07-06  1:40                       ` Drew Adams
2013-07-06  9:18                         ` Stefan Monnier
2013-07-06 20:22                           ` Drew Adams
2013-10-20 23:27               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9mat176.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=14734@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).