bug#4445: what-page and first line of page?

bug#4445: what-page and first line of page?

[Juanma Barranquero]

On Tue, Sep 15, 2009 at 03:22, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> I removed the beginning-of-line (has been there since the original
> commit 1.1 in 1989).

Strangely enough, that `beginning-of-line' somewhat masked a bug in
`what-page' that happens when `re-search-forward' matches but does not
move the point.

For example,

  emacs -Q lisp/ChangeLog
  M-x what-page <RET>         => "Page 1, line 1"

but

  emacs -Q lisp/ChangeLog
  <right>
  M-x what-page <RET>        => loops until C-g

This happens in ChangeLog files because `page-delimiter' has the value
"^\\<\\|^\f", which matches the empty string at the beginning of the
buffer.

I said the change "somewhat masked" the bug because before it, when
the point was on the first line of a ChangeLog, opoint was 1 (because
of the beginning-of-line), so the match failed and `what-page'
terminated. It only looped from line 2 on, while now it loops from
point 2 on.

    Juanma

bug#4447: what-page and first line of page?

[Stefan Monnier]

> Strangely enough, that `beginning-of-line' somewhat masked a bug in
> `what-page' that happens when `re-search-forward' matches but does not
> move the point.

Thanks, fixed,


        Stefan

bug#4445: what-page and first line of page?

[Juanma Barranquero]

On Wed, Sep 16, 2009 at 15:15, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Thanks, fixed,

Not yet, I think.

2009-09-16  Stefan Monnier  <monnier@iro.umontreal.ca>
^
Page 1, line 1

2009-09-16  Stefan Monnier  <monnier@iro.umontreal.ca>
 ^
Page 2, line 1

2009-09-16  Stefan Monnier  <monnier@iro.umontreal.ca>
  ^
Page 2, line 2

though I'd say that's a problem with the `page-delimiter' regexp for
change-log-mode, not with `what-page' itself.

    Juanma