* bug#10168: "Complete, but not unique" wrong
@ 2011-11-30 11:18 jidanni
2011-12-01 19:37 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: jidanni @ 2011-11-30 11:18 UTC (permalink / raw)
To: 10168
ESC x m a n RET d l o TAB
gives
Manual entry: dlo [Complete, but not unique]
Possible completions are:
dlocate(1)
dlopen(3)
So we see "[Complete, but not unique]" is wrong here, as it is not complete.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#10168: "Complete, but not unique" wrong
2011-11-30 11:18 bug#10168: "Complete, but not unique" wrong jidanni
@ 2011-12-01 19:37 ` Stefan Monnier
2011-12-01 22:16 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-12-01 19:37 UTC (permalink / raw)
To: jidanni; +Cc: 10168
> ESC x m a n RET d l o TAB
> gives
> Manual entry: dlo [Complete, but not unique]
> Possible completions are:
> dlocate(1)
> dlopen(3)
> So we see "[Complete, but not unique]" is wrong here, as it is not complete.
Indeed. I've installed the patch below which should fix those problems.
Stefan
--- lisp/man.el 2011-11-27 04:43:11 +0000
+++ lisp/man.el 2011-12-01 19:33:36 +0000
@@ -754,8 +754,10 @@
(defun Man-completion-table (string pred action)
(cond
- ((eq action 'lambda)
- (not (string-match "([^)]*\\'" string)))
+ ;; This ends up returning t for pretty much any string, and hence leads to
+ ;; spurious "complete but not unique" messages. And since `man' doesn't
+ ;; require-match anyway, there's not point being clever.
+ ;;((eq action 'lambda) (not (string-match "([^)]*\\'" string)))
((equal string "-k")
;; Let SPC (minibuffer-complete-word) insert the space.
(complete-with-action action '("-k ") string pred))
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#10168: "Complete, but not unique" wrong
2011-12-01 19:37 ` Stefan Monnier
@ 2011-12-01 22:16 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2011-12-01 22:16 UTC (permalink / raw)
To: 10168-done
Should be fixed now,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-01 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-30 11:18 bug#10168: "Complete, but not unique" wrong jidanni
2011-12-01 19:37 ` Stefan Monnier
2011-12-01 22:16 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).