From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com
Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group
Date: Thu, 03 Sep 2020 22:24:14 -0400 [thread overview]
Message-ID: <jwvpn72gu44.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvwo1gysla.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 30 Aug 2020 13:03:54 -0400")
>> How about doing the former on emacs-27, and the latter on master?
> Oh, indeed, I did not intend to change define-minor-mode on the
> emacs-27 branch.
> So, we have a deal!
O, so I looked into fixing it on `emacs-27` and it's not quite as
straightforward as I thought. Here's the patch that I have currently,
because without that `cus-dep.el` patch, the
`define-globalized-minor-mode` is just completely ignored by
cus-dep anyway.
I think it's quite safe, but I'd like to make sure you agree this is
acceptable for `emacs-27`.
Stefan
diff --git a/lisp/cus-dep.el b/lisp/cus-dep.el
index fd307a5c04..e2fd7febd2 100644
--- a/lisp/cus-dep.el
+++ b/lisp/cus-dep.el
@@ -99,7 +99,7 @@ custom-make-dependencies
(setq name (intern name)))
(condition-case nil
(while (re-search-forward
- "^(def\\(custom\\|face\\|group\\)" nil t)
+ "^(def\\(custom\\|face\\|group\\|ine\\(?:-globalized\\)?-minor-mode\\)" nil t)
(beginning-of-line)
(let ((type (match-string 1))
(expr (read (current-buffer))))
diff --git a/lisp/display-fill-column-indicator.el b/lisp/display-fill-column-indicator.el
index 3f947bdc1c..3391aa371b 100644
--- a/lisp/display-fill-column-indicator.el
+++ b/lisp/display-fill-column-indicator.el
@@ -73,7 +73,9 @@ display-fill-column-indicator--turn-on
;;;###autoload
(define-globalized-minor-mode global-display-fill-column-indicator-mode
- display-fill-column-indicator-mode display-fill-column-indicator--turn-on)
+ display-fill-column-indicator-mode display-fill-column-indicator--turn-on
+ ;; See bug#41145
+ :group 'display-fill-column-indicator)
(provide 'display-fill-column-indicator)
next prev parent reply other threads:[~2020-09-04 2:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 8:30 bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Philipp Stephani
2020-05-09 9:37 ` Eli Zaretskii
2020-05-09 12:31 ` Philipp Stephani
2020-08-28 14:48 ` Mauro Aranda
2020-08-29 6:54 ` Eli Zaretskii
2020-08-29 15:36 ` Stefan Monnier
2020-08-29 16:23 ` Mauro Aranda
2020-08-30 3:58 ` Stefan Monnier
2020-08-30 11:52 ` Mauro Aranda
2020-08-30 14:51 ` Stefan Monnier
2020-08-30 15:09 ` Eli Zaretskii
2020-08-30 17:03 ` Stefan Monnier
2020-09-04 2:24 ` Stefan Monnier [this message]
2020-09-04 7:09 ` Eli Zaretskii
2020-09-04 12:47 ` Stefan Monnier
2020-08-30 15:09 ` Drew Adams
2020-09-11 23:26 ` Michael Heerdegen
2020-09-12 15:43 ` Stefan Monnier
2020-09-12 18:51 ` Michael Heerdegen
2020-08-30 13:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpn72gu44.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=41145@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=maurooaranda@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).