From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Thu, 03 Sep 2020 22:24:14 -0400 Message-ID: References: <837dtiymay.fsf@gnu.org> <838sdwxjac.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17720"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 04:25:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE1PZ-0004VK-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 04:25:09 +0200 Original-Received: from localhost ([::1]:35690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE1PY-0002Mf-8T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 22:25:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE1PS-0002MY-TD for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 22:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE1PS-0004ee-Jz for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 22:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kE1PS-00044O-G1 for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 22:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 02:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41145 X-GNU-PR-Package: emacs Original-Received: via spool by 41145-submit@debbugs.gnu.org id=B41145.159918626515596 (code B ref 41145); Fri, 04 Sep 2020 02:25:02 +0000 Original-Received: (at 41145) by debbugs.gnu.org; 4 Sep 2020 02:24:25 +0000 Original-Received: from localhost ([127.0.0.1]:36688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1Oq-00043U-UW for submit@debbugs.gnu.org; Thu, 03 Sep 2020 22:24:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1Op-00043G-1a for 41145@debbugs.gnu.org; Thu, 03 Sep 2020 22:24:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9B49E100240; Thu, 3 Sep 2020 22:24:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BAAC1100216; Thu, 3 Sep 2020 22:24:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599186255; bh=u+p1kituR8cOFMTN3ilxT0ayFOuh41YYDT0VG4eC3zQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h0zxkPcBd7ajrrO/qSk5tuC5GOCXB/VZYoj1hPugXWc3PUcMTwLv+5GU6gdtXuXel 0zI2TO6XlM08dWsy39f0/kY2fHfXGIXWxGKCrrB6aue7b6BoKGmyPYyK2jD4NcwjFv kWp7yd01TelJ86YWSEcR/IKDhzN3jvdALI4r3jOsVpSh1bvHYtFe+Ija1RZu41iLz8 nfb9JxDIQJUhYrXZ806hbszPIUn0dOdPE/ZhXgFQaLIsdEU6/x4AcuWuHt64inumkV p2antDIcTQJywht9/4XQ4gzOx6pRnhErafbt+VpB7K2nsYRv6bZLZ+SBedzA9ptXyr eEmdlphfbvT/g== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F72812038D; Thu, 3 Sep 2020 22:24:15 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 30 Aug 2020 13:03:54 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187061 Archived-At: >> How about doing the former on emacs-27, and the latter on master? > Oh, indeed, I did not intend to change define-minor-mode on the > emacs-27 branch. > So, we have a deal! O, so I looked into fixing it on `emacs-27` and it's not quite as straightforward as I thought. Here's the patch that I have currently, because without that `cus-dep.el` patch, the `define-globalized-minor-mode` is just completely ignored by cus-dep anyway. I think it's quite safe, but I'd like to make sure you agree this is acceptable for `emacs-27`. Stefan diff --git a/lisp/cus-dep.el b/lisp/cus-dep.el index fd307a5c04..e2fd7febd2 100644 --- a/lisp/cus-dep.el +++ b/lisp/cus-dep.el @@ -99,7 +99,7 @@ custom-make-dependencies (setq name (intern name))) (condition-case nil (while (re-search-forward - "^(def\\(custom\\|face\\|group\\)" nil t) + "^(def\\(custom\\|face\\|group\\|ine\\(?:-globalized\\)?-minor-mode\\)" nil t) (beginning-of-line) (let ((type (match-string 1)) (expr (read (current-buffer)))) diff --git a/lisp/display-fill-column-indicator.el b/lisp/display-fill-column-indicator.el index 3f947bdc1c..3391aa371b 100644 --- a/lisp/display-fill-column-indicator.el +++ b/lisp/display-fill-column-indicator.el @@ -73,7 +73,9 @@ display-fill-column-indicator--turn-on ;;;###autoload (define-globalized-minor-mode global-display-fill-column-indicator-mode - display-fill-column-indicator-mode display-fill-column-indicator--turn-on) + display-fill-column-indicator-mode display-fill-column-indicator--turn-on + ;; See bug#41145 + :group 'display-fill-column-indicator) (provide 'display-fill-column-indicator)