* bug#49674: 28.0.50; Should unload-feature remove advices?
@ 2021-07-21 2:38 Michael Heerdegen
2021-07-21 14:57 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Michael Heerdegen @ 2021-07-21 2:38 UTC (permalink / raw)
To: 49674
Hello,
While talking about the text about FEATURE-unload-hook in
(info "(elisp) Coding Conventions") (Bug#21440) the question was raised
whether `unload-feature' should try to automatically remove advices
(nadvice style) that belong to functions defined by the unloaded
feature. Currently these are ignored. I guess it would be a good
thing. AFAICT old-style advices were (and are) handled.
And the docstring of `unload-feature' covers a lot of cases to care
about manually, but it doesn't mention advices. Should it?
TIA,
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49674: 28.0.50; Should unload-feature remove advices?
2021-07-21 2:38 bug#49674: 28.0.50; Should unload-feature remove advices? Michael Heerdegen
@ 2021-07-21 14:57 ` Lars Ingebrigtsen
2021-07-21 15:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-21 14:57 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Stefan Monnier, 49674
Michael Heerdegen <michael_heerdegen@web.de> writes:
> While talking about the text about FEATURE-unload-hook in
> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
> whether `unload-feature' should try to automatically remove advices
> (nadvice style) that belong to functions defined by the unloaded
> feature. Currently these are ignored. I guess it would be a good
> thing. AFAICT old-style advices were (and are) handled.
I think that sounds like a good idea, but perhaps Stefan has a comment
here (added to the CCs).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49674: 28.0.50; Should unload-feature remove advices?
2021-07-21 14:57 ` Lars Ingebrigtsen
@ 2021-07-21 15:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-07-21 15:14 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Michael Heerdegen, 49674
Lars Ingebrigtsen [2021-07-21 16:57:56] wrote:
> Michael Heerdegen <michael_heerdegen@web.de> writes:
>> While talking about the text about FEATURE-unload-hook in
>> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
>> whether `unload-feature' should try to automatically remove advices
>> (nadvice style) that belong to functions defined by the unloaded
>> feature. Currently these are ignored. I guess it would be a good
>> thing. AFAICT old-style advices were (and are) handled.
> I think that sounds like a good idea, but perhaps Stefan has a comment
> here (added to the CCs).
Sounds good to me, yes.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-21 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 2:38 bug#49674: 28.0.50; Should unload-feature remove advices? Michael Heerdegen
2021-07-21 14:57 ` Lars Ingebrigtsen
2021-07-21 15:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).