bug#15235: 24.3.50; package.el updates load-path too late

bug#15235: 24.3.50; package.el updates load-path too late

[Richard Kim]

A recent change made on bzr trunk is causing one of my ELPA packages to
fail to load due to `load-path' not being updated promptly.

The change in question seems to be Stefan's revision 114047 checked in
on Aug 28, 2013 with check in comment

    Don't add unnecessarily to load-path.

The package in question is icicles which I created by putting together a
few files from emacswiki.org which I have been using for several years.

The problem is that icicles-autoloads.el refers to some custom face
which is provided by icicles-face.el in the icicles package directory.
However Stefan's change now evaluates icicles-autoloads.el first then
updates load-path to add path for icicles.  Following shows
`package-activate-1' from around August 24:

    (defun package-activate-1 (pkg-desc)
      (let* ((name (package-desc-name pkg-desc))
    	 (pkg-dir (package-desc-dir pkg-desc)))
        (unless pkg-dir
          (error "Internal error: unable to find directory for `%s'"
    	     (package-desc-full-name pkg-desc)))
        ;; Add info node.
        (when (file-exists-p (expand-file-name "dir" pkg-dir))
          ;; FIXME: not the friendliest, but simple.
          (require 'info)
          (info-initialize)
          (push pkg-dir Info-directory-list))
        ;; Add to load path, add autoloads, and activate the package.
        (push pkg-dir load-path)
        (load (expand-file-name (format "%s-autoloads" name) pkg-dir) nil t)
        (push name package-activated-list)
        ;; Don't return nil.
        t))

Note that (load) of the "-autolads" file comes after updating of
load-path, i.e., (push pkg-dir load-path).  Thus icicles-face.el can be
found in this version of package.el.

Shouldn't load-path updated first for the packge being intialized so
that code in "*-autoloads.el" can load other elisp files in the package
directory?

bug#15235: Acknowledgement (24.3.50; package.el updates load-path too late)

[Richard Kim]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

After looking into this further, I learned that reinstalling packages adds
code in *-autoloads.el file to set load-path.

So my problem was resolved by reinstalling all my private ELPA packages.

As far as I'm concerned, this is no longer a bug.
However it looks like recent change in package.el requires everyone to
reinstall all their packages!



On 1 September 2013 09:47, GNU bug Tracking System <help-debbugs@gnu.org>wrote:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  bug-gnu-emacs@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 15235@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 15235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15235
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>

[-- Attachment #2: Type: text/html, Size: 1978 bytes --]

bug#15235: 24.3.50; package.el updates load-path too late

[Stefan Monnier]

> Shouldn't load-path updated first for the packge being intialized so
> that code in "*-autoloads.el" can load other elisp files in the package
> directory?

Actually, "nowadays" the *-autoloads.el file should begin by adding to
load-path so package.el doesn't need to do it any more.


        Stefan

bug#15235: Acknowledgement (24.3.50; package.el updates load-path too late)

[Stefan Monnier]

> However it looks like recent change in package.el requires everyone to
> reinstall all their packages!

Not really: normally the *-autoloads.el file does not require loading
any other file.


        Stefan

bug#15235: 24.3.50; package.el updates load-path too late

[Noam Postavsky]

Closing since everyone using 24.3.50 must have updated their
*-autoloads.el files by now.