From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Leo Liu <sdl.web@gmail.com>, 19066@debbugs.gnu.org
Subject: bug#19066: 25.0.50; nadvice and interactive-form
Date: Mon, 31 May 2021 08:49:27 -0400 [thread overview]
Message-ID: <jwvlf7vul30.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87czt7lapl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 31 May 2021 07:43:34 +0200")
Lars Ingebrigtsen [2021-05-31 07:43:34] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Another way would be to make the interactive form of the "compose
>> function" more dynamic: make it re-checks the interactive form of every
>> advice function every time. That's probably the better option.
> That sounds like a good solution to me -- the interactive path isn't
> normally performance critical, so adding more work in that case should
> be fine.
Yes, performance is not an issue. But preserving the semantics 100% is
currently somewhere between hard and impossible. 99.9% is fairly easy,
OTOH (IIRC the main problem has to do with how the args get represented
in `command-history`).
Stefan
prev parent reply other threads:[~2021-05-31 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 10:00 bug#19066: 25.0.50; nadvice and interactive-form Leo Liu
2021-05-28 2:11 ` Lars Ingebrigtsen
2021-05-30 17:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-31 5:43 ` Lars Ingebrigtsen
2021-05-31 12:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlf7vul30.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=19066@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).