From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#19066: 25.0.50; nadvice and interactive-form Date: Mon, 31 May 2021 08:49:27 -0400 Message-ID: References: <87y4rbtqh6.fsf@gmail.com> <87r1hry5dq.fsf@gnus.org> <87czt7lapl.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5285"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Leo Liu , 19066@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 14:50:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnhNB-0001CJ-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 14:50:25 +0200 Original-Received: from localhost ([::1]:57450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnhNA-0008Nx-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 08:50:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnhMo-0008Lw-Dj for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 08:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnhMn-0008C7-OV for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 08:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnhMn-0007Xp-NE for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 08:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 12:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 19066-submit@debbugs.gnu.org id=B19066.162246537928966 (code B ref 19066); Mon, 31 May 2021 12:50:01 +0000 Original-Received: (at 19066) by debbugs.gnu.org; 31 May 2021 12:49:39 +0000 Original-Received: from localhost ([127.0.0.1]:32954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnhMQ-0007X8-MV for submit@debbugs.gnu.org; Mon, 31 May 2021 08:49:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnhMO-0007Wv-MS for 19066@debbugs.gnu.org; Mon, 31 May 2021 08:49:37 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D4545440537; Mon, 31 May 2021 08:49:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0EF9E440071; Mon, 31 May 2021 08:49:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622465369; bh=8i8PJrcEihrdwTov6V1BZ8RXQ09sKuXVsx6sWgkav6Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VCF9fHvmhEM1mNfrE65MgARqhE/VSNk63XRQCG+8pI1DOmxGbs3wdhZq1h7/RxwrJ jNDqmR2OtQ4FnmKgkP5Lgf8oJ14tgKdRFE5r4bK3FIctEfQCWhaj/T5iBLFGUzfnUX Vr2u3iIE++fC1MKqVrHIvzojFe6kPWakx75STSU+zhqZdIhQ3hr595F9cHjNhBX/Hc OGDmRF11pJggJsiMt8NEA7kcjHSMbg2QgTZu9Et1HMhZvbJFNon01HKBqIzdb/Om7P gGAW7dun/0bHh/mRea3LCrWMBcIX2dKYQLpbIfpWuv3N+mFOjNjb+XwjFIGGOeuHCM R570/l0ixbxLA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BECF9121053; Mon, 31 May 2021 08:49:28 -0400 (EDT) In-Reply-To: <87czt7lapl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 31 May 2021 07:43:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207696 Archived-At: Lars Ingebrigtsen [2021-05-31 07:43:34] wrote: > Stefan Monnier writes: >> Another way would be to make the interactive form of the "compose >> function" more dynamic: make it re-checks the interactive form of every >> advice function every time. That's probably the better option. > That sounds like a good solution to me -- the interactive path isn't > normally performance critical, so adding more work in that case should > be fine. Yes, performance is not an issue. But preserving the semantics 100% is currently somewhere between hard and impossible. 99.9% is fairly easy, OTOH (IIRC the main problem has to do with how the args get represented in `command-history`). Stefan