From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 45029@debbugs.gnu.org
Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode
Date: Wed, 13 Sep 2023 13:59:55 -0400 [thread overview]
Message-ID: <jwvledahs3i.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv8r9aj7u3.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 13 Sep 2023 13:36:54 -0400")
Stefan Monnier [2023-09-13 13:36:54] wrote:
> Here is a brief trace that explains the cause of the problem:
>
> 1. C-y (yank) calls delete-selection-pre-hook from pre-command-hook
> 2. delete-selection-helper calls delete-active-region
> 3. this activates ask-user-about-supersession-threat on a modified file
> 4. it calls read-char-from-minibuffer ('this-command' is still 'yank')
> 5. read-char-from-minibuffer waits when user types 'y'
> (bound to the command 'read-char-from-minibuffer-insert-char')
> 6. after typing 'y', read-char-from-minibuffer returns 'y', but
> now 'this-command' is 'read-char-from-minibuffer-insert-char'
> 7. when delete-selection-pre-hook finishes, due to 'this-command'
> 'read-char-from-minibuffer-insert-char' is called again,
> and this time operates on the buffer as if it's the minibuffer
Yuck!
And thanks for the investigation.
> Anyway, here is a patch with two fixes:
> 1. Guards read-char-from-minibuffer-insert-char against inadvertent
> operating on the non-minibuffer buffer;
I suspect this will/would just hide a problem (such as the current one)
under the rug.
> 2. Prevents read-char-from-minibuffer from changing the value of
> 'this-command' by read-from-minibuffer:
Right, but I think that this needs to apply to all recursive edits
rather than only `read-char-from-minibuffer`.
Stefan
next prev parent reply other threads:[~2023-09-13 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 20:10 bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode Lars Ljung
2020-12-04 10:18 ` Lars Ingebrigtsen
2020-12-05 11:31 ` Eli Zaretskii
2020-12-05 19:42 ` Juri Linkov
2020-12-05 20:04 ` Eli Zaretskii
2020-12-06 21:12 ` Juri Linkov
2020-12-07 3:27 ` Eli Zaretskii
[not found] ` <jwv8r9aj7u3.fsf-monnier+emacs@gnu.org>
2023-09-13 17:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-14 6:39 ` Juri Linkov
2023-09-14 13:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 6:36 ` Juri Linkov
2023-09-15 13:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 16:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvledahs3i.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=45029@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).