From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 45029@debbugs.gnu.org
Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode
Date: Fri, 15 Sep 2023 09:36:12 +0300 [thread overview]
Message-ID: <868r986k8n.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvedj027s2.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 14 Sep 2023 09:44:00 -0400")
>>>> Anyway, here is a patch with two fixes:
>>>> 1. Guards read-char-from-minibuffer-insert-char against inadvertent
>>>> operating on the non-minibuffer buffer;
>>> I suspect this will/would just hide a problem (such as the current one)
>>> under the rug.
>> I admit this is a workaround, but I have no idea what would be a proper fix.
>
> The let-binding of `this-command` fixes the problem, doesn't it?
But might other uses of a recursive edit break it again?
I guess `when (minibufferp)` can't be removed
from `read-char-from-minibuffer-insert-other`
until all cases below are fixed.
>>>> 2. Prevents read-char-from-minibuffer from changing the value of
>>>> 'this-command' by read-from-minibuffer:
>>> Right, but I think that this needs to apply to all recursive edits
>>> rather than only `read-char-from-minibuffer`.
>> I tried to test recursive commands at the read-char-from-minibuffer's
>> prompt, but can't reproduce the same problem.
>
> No, I mean other uses of a recursive edit from `pre-command-hook` would
> cause the same problem, so the let-binding should be placed deeper than
> in `read-char-from-minibuffer`, e.g. inside `recursive_edit_1`.
I see, so this problem is more general and not specific to
`read-char-from-minibuffer`? It would be nice to find
a test case for other commands to confirm that a change in
`recursive_edit_1` fixes them.
next prev parent reply other threads:[~2023-09-15 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 20:10 bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode Lars Ljung
2020-12-04 10:18 ` Lars Ingebrigtsen
2020-12-05 11:31 ` Eli Zaretskii
2020-12-05 19:42 ` Juri Linkov
2020-12-05 20:04 ` Eli Zaretskii
2020-12-06 21:12 ` Juri Linkov
2020-12-07 3:27 ` Eli Zaretskii
[not found] ` <jwv8r9aj7u3.fsf-monnier+emacs@gnu.org>
2023-09-13 17:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 6:39 ` Juri Linkov
2023-09-14 13:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 6:36 ` Juri Linkov [this message]
2023-09-15 13:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 16:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868r986k8n.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=45029@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).