From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 43558@debbugs.gnu.org, "Mattias Engdegård" <mattiase@acm.org>,
"Dmitry Gutov" <dgutov@yandex.ru>
Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped.
Date: Sun, 22 Nov 2020 18:00:40 -0500 [thread overview]
Message-ID: <jwvk0udnh2c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20201122220110.GI5912@ACM> (Alan Mackenzie's message of "Sun, 22 Nov 2020 22:01:10 +0000")
> It provides a mechanism which might be useful to other major modes in
> the future.
FWIW, I doubt it.
In my experience these details never quite match.
>> With user experience (speed, latencies, etc) being equal or within the
>> margin of error, I think it's more logical to go with simpler data
>> structures and low level APIs.
> Fixing things in syntax.c was simpler than a Lisp solution using
> syntax-table text properties would have been.
I find it hard to take this statement seriously after having seen my
sm-c-mode patch.
>> Finally, as I recall you feel strongly about supporting older Emacs
>> versions, a significant number of them. Doing that fix in Lisp would
>> allow you to fix the bug for those versions too. Not just Emacs 28+.
> Yes. That appears to be the sole drawback of the fix being in syntax.c.
I don't really find this to be a drawback since I don't care about
CC-mode's support for multiline `//` comments in older Emacsen.
But the added complexity in the C code and in the API documentation for the
sole benefit of C (and C++?) mode is a drawback, yes.
I do want to clarify my position, tho: while I don't like your patch
very much because I think a Lisp-level solution (like the one I used in
sm-c-mode) is preferable I find your patch acceptable.
Stefan
next prev parent reply other threads:[~2020-11-22 23:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 9:35 bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped Alan Mackenzie
2020-09-22 14:09 ` Stefan Monnier
2020-09-22 19:41 ` Alan Mackenzie
[not found] ` <handler.43558.B.160076736116422.ack@debbugs.gnu.org>
2020-09-23 8:57 ` Alan Mackenzie
2020-09-23 9:01 ` Mattias Engdegård
2020-09-23 14:48 ` Alan Mackenzie
2020-09-23 18:44 ` Stefan Monnier
2020-09-23 19:44 ` Alan Mackenzie
2020-09-23 20:02 ` Stefan Monnier
2020-09-24 10:20 ` Alan Mackenzie
2020-09-24 16:56 ` Stefan Monnier
2020-09-24 18:50 ` Alan Mackenzie
2020-09-24 22:43 ` Stefan Monnier
2020-11-19 21:18 ` Alan Mackenzie
2020-11-19 22:47 ` Stefan Monnier
2020-11-22 13:12 ` Alan Mackenzie
2020-11-22 15:20 ` Stefan Monnier
2020-11-22 17:08 ` Alan Mackenzie
2020-11-22 17:46 ` Dmitry Gutov
2020-11-22 18:19 ` Alan Mackenzie
2020-11-22 20:39 ` Dmitry Gutov
2020-11-22 21:13 ` Alan Mackenzie
2020-11-22 21:34 ` Dmitry Gutov
2020-11-22 22:01 ` Alan Mackenzie
2020-11-22 23:00 ` Stefan Monnier [this message]
2021-05-13 10:38 ` Lars Ingebrigtsen
2021-05-13 14:51 ` Alan Mackenzie
2021-05-16 13:53 ` Lars Ingebrigtsen
2022-04-28 11:17 ` Lars Ingebrigtsen
2022-04-28 18:52 ` Alan Mackenzie
2020-11-22 23:10 ` Stefan Monnier
2020-11-22 15:35 ` Eli Zaretskii
2020-11-22 17:03 ` Alan Mackenzie
2020-09-24 18:52 ` Michael Welsh Duggan
2020-09-24 19:57 ` Alan Mackenzie
2020-09-24 20:27 ` Michael Welsh Duggan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk0udnh2c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=43558@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=dgutov@yandex.ru \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).