* bug#47925: 28.0.50; define-minor-mode without body results in false warning
@ 2021-04-20 22:24 Jonas Bernoulli
2021-04-20 23:41 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2021-04-20 22:24 UTC (permalink / raw)
To: 47925
I have a mode that leaves out all the optional arguments because its
sole purpose is the enable its minor-mode map:
(define-minor-mode transient-resume-mode
"Auxiliary minor-mode used to resume a transient after viewing help.")
which is supported:
(define-minor-mode MODE DOC [KEYWORD VAL ... &rest BODY])
Unfortunately that results in a warning:
transient.el:3318:20: Warning: Use keywords rather than deprecated positional
arguments to `define-minor-mode'
because INIT-VALUE is nil in this case, not keywordp.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#47925: 28.0.50; define-minor-mode without body results in false warning
2021-04-20 22:24 bug#47925: 28.0.50; define-minor-mode without body results in false warning Jonas Bernoulli
@ 2021-04-20 23:41 ` Stefan Monnier
2021-04-27 7:28 ` Jonas Bernoulli
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2021-04-20 23:41 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: 47925
> (define-minor-mode transient-resume-mode
> "Auxiliary minor-mode used to resume a transient after viewing help.")
[...]
> Unfortunately that results in a warning:
>
> transient.el:3318:20: Warning: Use keywords rather than deprecated positional
> arguments to `define-minor-mode'
I have pushed a patch to `master` which hopefully fixes this without
introducing regressions.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#47925: 28.0.50; define-minor-mode without body results in false warning
2021-04-20 23:41 ` Stefan Monnier
@ 2021-04-27 7:28 ` Jonas Bernoulli
2021-04-27 13:27 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2021-04-27 7:28 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 47925
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I have pushed a patch to `master` which hopefully fixes this without
> introducing regressions.
That seems to be working. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#47925: 28.0.50; define-minor-mode without body results in false warning
2021-04-27 7:28 ` Jonas Bernoulli
@ 2021-04-27 13:27 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2021-04-27 13:27 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: 47925-done
>> I have pushed a patch to `master` which hopefully fixes this without
>> introducing regressions.
> That seems to be working. Thanks!
Thanks, closing,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-27 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 22:24 bug#47925: 28.0.50; define-minor-mode without body results in false warning Jonas Bernoulli
2021-04-20 23:41 ` Stefan Monnier
2021-04-27 7:28 ` Jonas Bernoulli
2021-04-27 13:27 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).