From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: miha@kamnitnik.top
Cc: 48925@debbugs.gnu.org
Subject: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places
Date: Tue, 20 Jul 2021 10:29:40 -0400 [thread overview]
Message-ID: <jwvk0ll5air.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fsxstdiy.fsf@miha-pc> (miha@kamnitnik.top's message of "Tue, 08 Jun 2021 20:30:29 +0200")
> This follows up on changes proposed in bug#45474.
Thanks, the first patch looks good to me (assuming it works ;-).
> The second patch is a bit more controversial, but is probably required
> if we want more reliable usage of completion commands in non-innermost
> minibuffers (that is, with minibuffer-follows-selected-frame set
> to nil.)
The patch is fundamentally right, but as you say it's a bit more
controversial because it risks exposing bugs. Hmm...
To be on the safer side, I guess we could replace the
specbind (Qminibuffer_completion_table, Qnil);
with a use of `minibuffer-with-setup-hook` that sets the var to nil in
the new minibuffer. But doing it in C is awkward so it would best be
done by moving the function to subr.el.
Stefan
next prev parent reply other threads:[~2021-07-20 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 18:30 bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-20 12:30 ` Lars Ingebrigtsen
2021-07-20 14:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-11 5:19 ` Lars Ingebrigtsen
2021-11-11 10:42 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-11 11:27 ` Eli Zaretskii
2021-11-11 12:11 ` Lars Ingebrigtsen
2021-11-11 14:17 ` Eli Zaretskii
2021-11-11 16:50 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-12 2:47 ` Lars Ingebrigtsen
2021-11-12 8:57 ` Eli Zaretskii
2021-11-14 0:49 ` Lars Ingebrigtsen
2021-11-14 6:57 ` Eli Zaretskii
2021-11-15 5:31 ` Lars Ingebrigtsen
2021-11-11 13:04 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-11 23:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-12 0:22 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk0ll5air.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=48925@debbugs.gnu.org \
--cc=miha@kamnitnik.top \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).