From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places Date: Tue, 20 Jul 2021 10:29:40 -0400 Message-ID: References: <87fsxstdiy.fsf@miha-pc> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29791"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48925@debbugs.gnu.org To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 20 16:30:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5ql9-0007Z7-V5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 16:30:12 +0200 Original-Received: from localhost ([::1]:46484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5ql9-0006JO-17 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 10:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5ql0-0006Is-Dx for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5ql0-0006DJ-6I for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5qkz-00033h-RX for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2021 14:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48925-submit@debbugs.gnu.org id=B48925.162679139111721 (code B ref 48925); Tue, 20 Jul 2021 14:30:01 +0000 Original-Received: (at 48925) by debbugs.gnu.org; 20 Jul 2021 14:29:51 +0000 Original-Received: from localhost ([127.0.0.1]:35009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qkp-00032y-2p for submit@debbugs.gnu.org; Tue, 20 Jul 2021 10:29:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qkn-00032i-9E for 48925@debbugs.gnu.org; Tue, 20 Jul 2021 10:29:50 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D885E440B4E; Tue, 20 Jul 2021 10:29:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B6D88440AA8; Tue, 20 Jul 2021 10:29:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1626791381; bh=01dKd1f23y8nDHP5nlDjXhZEn5vOfk43J0HeO6eExV4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oPozPEqXikUgsOUIkb0gxl4j8PCezTxMsCVXJTKFfMPUYJPcYfDNKOyAlVr10v8PI +hoS9z9uxIXK0XsXfgvIWNRH4jiNUUUUWS/S0jyAXCdplFlFrk8N2dlA2JPQhYiRGC cpZ3WgQBEry3apXUPEYZVggID1FYVXDicbRSATt382AYozrZ4dMidbkGH60F9t2Y7A MP0Zxrd2A8mJA6IVecqBrrheHZdp8djIzDQh2fMbfkTE8df8fQnUbnqcRo424xF2i8 bf6A9a3qa5yqZoxtaAIAjJdRxFWkM4mHMtjYdMZnibvhWo2uvQleBizFM3UvHyQR+F w16Xwj8JJ2vYQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 58AE91200E2; Tue, 20 Jul 2021 10:29:41 -0400 (EDT) In-Reply-To: <87fsxstdiy.fsf@miha-pc> (miha@kamnitnik.top's message of "Tue, 08 Jun 2021 20:30:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210359 Archived-At: > This follows up on changes proposed in bug#45474. Thanks, the first patch looks good to me (assuming it works ;-). > The second patch is a bit more controversial, but is probably required > if we want more reliable usage of completion commands in non-innermost > minibuffers (that is, with minibuffer-follows-selected-frame set > to nil.) The patch is fundamentally right, but as you say it's a bit more controversial because it risks exposing bugs. Hmm... To be on the safer side, I guess we could replace the specbind (Qminibuffer_completion_table, Qnil); with a use of `minibuffer-with-setup-hook` that sets the var to nil in the new minibuffer. But doing it in C is awkward so it would best be done by moving the function to subr.el. Stefan