* bug#10200: 24.0.92; Message buffer pops up in new window
@ 2011-12-03 3:11 Chong Yidong
2011-12-03 3:55 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2011-12-03 3:11 UTC (permalink / raw)
To: 10200
With latest trunk:
emacs -Q
C-x m
The *unsent mail* buffer pops up in a different window.
This is a regression from the behavior in previous version of Emacs, and
it is caused by
revno: 106557
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Wed 2011-11-30 09:52:08 -0500
message:
* lisp/gnus/message.el (message-pop-to-buffer): Revert 2011-09-11 change.
What is the rationale for this change?
In GNU Emacs 24.0.92.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
of 2011-12-03 on furball
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10200: 24.0.92; Message buffer pops up in new window
2011-12-03 3:11 bug#10200: 24.0.92; Message buffer pops up in new window Chong Yidong
@ 2011-12-03 3:55 ` Stefan Monnier
2011-12-03 15:44 ` Drew Adams
2011-12-04 1:48 ` Chong Yidong
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-12-03 3:55 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10200
> With latest trunk:
> emacs -Q
> C-x m
> The *unsent mail* buffer pops up in a different window.
> This is a regression from the behavior in previous version of Emacs, and
> it is caused by
I reverted the code to what it was in Emacs-23 (i.e. calling
pop-to-buffer), so the difference must be elsewhere.
> What is the rationale for this change?
The reason for the reversion was that the new code (using
switch-to-buffer) ignored special-display-*. Maybe it should call
pop-to-buffer-same-window?
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10200: 24.0.92; Message buffer pops up in new window
2011-12-03 3:55 ` Stefan Monnier
@ 2011-12-03 15:44 ` Drew Adams
2011-12-04 1:48 ` Chong Yidong
1 sibling, 0 replies; 6+ messages in thread
From: Drew Adams @ 2011-12-03 15:44 UTC (permalink / raw)
To: 'Stefan Monnier', 'Chong Yidong'; +Cc: 10200
> > What is the rationale for this change?
>
> The reason for the reversion was that the new code (using
> switch-to-buffer) ignored special-display-*. Maybe it should call
> pop-to-buffer-same-window?
See bug #9532.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10200: 24.0.92; Message buffer pops up in new window
2011-12-03 3:55 ` Stefan Monnier
2011-12-03 15:44 ` Drew Adams
@ 2011-12-04 1:48 ` Chong Yidong
2011-12-04 10:40 ` martin rudalics
1 sibling, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2011-12-04 1:48 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 10200
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I reverted the code to what it was in Emacs-23 (i.e. calling
> pop-to-buffer), so the difference must be elsewhere.
>
>> What is the rationale for this change?
>
> The reason for the reversion was that the new code (using
> switch-to-buffer) ignored special-display-*. Maybe it should call
> pop-to-buffer-same-window?
In Emacs 23, message-mode relied on same-window-buffer-names to remain
on the same window. That's nil, now so you can't just call
pop-to-buffer there. I've checked in a fix.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10200: 24.0.92; Message buffer pops up in new window
2011-12-04 1:48 ` Chong Yidong
@ 2011-12-04 10:40 ` martin rudalics
2011-12-04 15:16 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2011-12-04 10:40 UTC (permalink / raw)
To: Chong Yidong; +Cc: 10200
> In Emacs 23, message-mode relied on same-window-buffer-names to remain
> on the same window. That's nil, now so you can't just call
> pop-to-buffer there. I've checked in a fix.
IMHO all former same-window-buffer-names/-regexps guarded calls of
`display-buffer' should use `pop-to-buffer-same-window' now.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#10200: 24.0.92; Message buffer pops up in new window
2011-12-04 10:40 ` martin rudalics
@ 2011-12-04 15:16 ` Stefan Monnier
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-12-04 15:16 UTC (permalink / raw)
To: martin rudalics; +Cc: Chong Yidong, 10200
>> In Emacs 23, message-mode relied on same-window-buffer-names to remain
>> on the same window. That's nil, now so you can't just call
>> pop-to-buffer there. I've checked in a fix.
> IMHO all former same-window-buffer-names/-regexps guarded calls of
> `display-buffer' should use `pop-to-buffer-same-window' now.
Yes, the proper replacement is pop-to-buffer-same-window, indeed.
But since we want to preserve backward compatibility with such code, we
don't *have* to replace them right away.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-04 15:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-03 3:11 bug#10200: 24.0.92; Message buffer pops up in new window Chong Yidong
2011-12-03 3:55 ` Stefan Monnier
2011-12-03 15:44 ` Drew Adams
2011-12-04 1:48 ` Chong Yidong
2011-12-04 10:40 ` martin rudalics
2011-12-04 15:16 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).