unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31397@debbugs.gnu.org, Radon Rosborough <radon.neon@gmail.com>,
	Zachary Kanfer <zkanfer@gmail.com>
Subject: bug#31397: 27.0.50; Emacs doesn't call package-initialize if there's no elpa directory
Date: Tue, 29 May 2018 18:58:42 -0400	[thread overview]
Message-ID: <jwvh8mq5aym.fsf-monnier+bug#31397@gnu.org> (raw)
In-Reply-To: <87fu2acchi.fsf@gmail.com> (Noam Postavsky's message of "Tue, 29 May 2018 18:40:09 -0400")

>> 1. Make `package-installed-p' and other functions automatically
>>    initialize package.el if necessary.

Yes, when I changed it recently I hesitated to do that and decided to
refrain from doing so in order to minimize the changes, but it makes
a lot of sense.


        Stefan


diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 94d98178c4..56be5ef70c 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1889,8 +1889,8 @@ package-installed-p
     ;; We used the quickstart: make it possible to use package-installed-p
     ;; even before package is fully initialized.
     (memq package package-activated-list))
-   ((not package--initialized) (error "package.el is not yet initialized!"))
    (t
+    (unless package--initialized (package-initialize 'no-activate))
     (or
      (let ((pkg-descs (cdr (assq package package-alist))))
        (and pkg-descs





  reply	other threads:[~2018-05-29 22:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  5:17 bug#31397: 27.0.50; Emacs doesn't call package-initialize if there's no elpa directory Zachary Kanfer
2018-05-29  2:41 ` bug#31397: 27.0.50; Emacs doesn't call package-initialize if there's no Zachary Kanfer
2018-05-29 11:52 ` bug#31397: 27.0.50; Emacs doesn't call package-initialize if there's no elpa directory Noam Postavsky
2018-05-29 16:13   ` Radon Rosborough
2018-05-29 22:40     ` Noam Postavsky
2018-05-29 22:58       ` Stefan Monnier [this message]
2018-08-06 23:41         ` Zachary Kanfer
2019-01-22 23:12           ` Stefan Monnier
2019-11-04 20:01             ` Stefan Kangas
2019-11-04 22:57               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvh8mq5aym.fsf-monnier+bug#31397@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=31397@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=radon.neon@gmail.com \
    --cc=zkanfer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).