bug#56621: [PATCH] info-edit: Delay `ibuffer' var change until after `ibuffer' loads

bug#56621: [PATCH] info-edit: Delay `ibuffer' var change until after `ibuffer' loads

[Richard Hansen]

[-- Attachment #1.1.1: Type: text/plain, Size: 368 bytes --]

Attached patch:

     info-edit: Delay `ibuffer' var change until after `ibuffer' loads

     * lisp/obsolete/info-edit.el: Delay the addition of `Info-edit-mode'
     to the `ibuffer-help-buffer-modes' list until after `ibuffer' is
     loaded.  This fixes a "(void-variable ibuffer-help-buffer-modes)"
     error when `info-edit' is loaded before `ibuffer'.

[-- Attachment #1.1.2: 0001-info-edit-Delay-ibuffer-var-change-until-after-ibuff.patch --]
[-- Type: text/x-patch, Size: 1447 bytes --]

From c71dc095a677518a8da65b2bea4360df3bd606fa Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Sun, 17 Jul 2022 14:32:42 -0400
Subject: [PATCH] info-edit: Delay `ibuffer' var change until after `ibuffer'
 loads

* lisp/obsolete/info-edit.el: Delay the addition of `Info-edit-mode'
to the `ibuffer-help-buffer-modes' list until after `ibuffer' is
loaded.  This fixes a "(void-variable ibuffer-help-buffer-modes)"
error when `info-edit' is loaded before `ibuffer'.
---
 lisp/obsolete/info-edit.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/obsolete/info-edit.el b/lisp/obsolete/info-edit.el
index 6c4c10ca6c..3bab77e245 100644
--- a/lisp/obsolete/info-edit.el
+++ b/lisp/obsolete/info-edit.el
@@ -77,11 +77,11 @@ Info-cease-edit
        (buffer-modified-p)
        (message "Tags may have changed.  Use Info-tagify if necessary")))
 
-(defvar ibuffer-help-buffer-modes)
-;; Moved here from definition of ibuffer-help-buffer-modes to make
-;; that variable customizable even though this code is obsolete.  See
-;; also Bug#30990.
-(add-to-list 'ibuffer-help-buffer-modes 'Info-edit-mode)
+(with-eval-after-load 'ibuffer
+  ;; Moved here from definition of ibuffer-help-buffer-modes to make
+  ;; that variable customizable even though this code is obsolete.  See
+  ;; also Bug#30990.
+  (add-to-list 'ibuffer-help-buffer-modes 'Info-edit-mode))
 
 (provide 'info-edit)
 
-- 
2.37.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#56621: [PATCH] info-edit: Delay `ibuffer' var change until after `ibuffer' loads

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Richard Hansen [2022-07-17 14:49:20] wrote:
>     info-edit: Delay `ibuffer' var change until after `ibuffer' loads

Thanks, pushed to `master`.


        Stefan