* bug#45346: [elpa-archive] :ignored-files is processed to early
@ 2020-12-20 20:41 Jonas Bernoulli
2020-12-20 22:04 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2020-12-20 20:41 UTC (permalink / raw)
To: 45346; +Cc: Stefan Monnier
Currently it is not possible to move some files out of a directory and
then ignore all the remaining files without having to specify each one
of them individually. Ignoring the directory overrides and `:renames'
that attempt to move some files out of the directory.
A second unfortunate effect is that the directory is added to the
tarball even though it is empty after moving or removing all files it
originally contained.
It appears that `:ignored-files' is processes before `:renames' and
that that should be changed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#45346: [elpa-archive] :ignored-files is processed to early
2020-12-20 20:41 bug#45346: [elpa-archive] :ignored-files is processed to early Jonas Bernoulli
@ 2020-12-20 22:04 ` Stefan Monnier
2020-12-21 10:20 ` Jonas Bernoulli
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-12-20 22:04 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: 45346
> It appears that `:ignored-files' is processes before `:renames' and
> that that should be changed.
Indeed, the renaming is applied last and it's not easy to change that
with the approach I use (the renaming is done by `tar` via
`--transform`).
Maybe I could try and remove the entries after generating the tarball.
Hmm...
Note, FWIW, I tend to consider that it's OK to keep useless files in the
tarball as long as they're not actively harmful (e.g. they triple the
size of the tarball), and more generally I think it's best to use
`:ignore` and `:renames` with moderation.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#45346: [elpa-archive] :ignored-files is processed to early
2020-12-20 22:04 ` Stefan Monnier
@ 2020-12-21 10:20 ` Jonas Bernoulli
2020-12-21 14:36 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2020-12-21 10:20 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 45346
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> It appears that `:ignored-files' is processes before `:renames' and
>> that that should be changed.
>
> Indeed, the renaming is applied last and it's not easy to change that
> with the approach I use (the renaming is done by `tar` via
> `--transform`).
>
> Maybe I could try and remove the entries after generating the tarball.
> Hmm...
IMO it would be better to just do it in lisp and simplify the call to
`tar'.
> Note, FWIW, I tend to consider that it's OK to keep useless files in the
> tarball as long as they're not actively harmful (e.g. they triple the
> size of the tarball), and more generally I think it's best to use
> `:ignore` and `:renames` with moderation.
I consider useless files to be actively harmful. Some users will
investigate what those apparently useless files are for and once they
have seen that they are in fact useless some of them still won't be
satisfied and continue to wonder what they have missed because obviously
nobody would include such useless files... I am like that and would
like to save others (plural) from having to do the same work over and
over again when I can just do it for them once.
Jonas
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#45346: [elpa-archive] :ignored-files is processed to early
2020-12-21 10:20 ` Jonas Bernoulli
@ 2020-12-21 14:36 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2020-12-21 14:36 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: 45346
>>> It appears that `:ignored-files' is processes before `:renames' and
>>> that that should be changed.
>> Indeed, the renaming is applied last and it's not easy to change that
>> with the approach I use (the renaming is done by `tar` via
>> `--transform`).
>> Maybe I could try and remove the entries after generating the tarball.
>> Hmm...
> IMO it would be better to just do it in lisp and simplify the call to `tar'.
BTW, in the mean time you can work around this by doing the
renames "by hand" in the `:make` rule.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-21 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-20 20:41 bug#45346: [elpa-archive] :ignored-files is processed to early Jonas Bernoulli
2020-12-20 22:04 ` Stefan Monnier
2020-12-21 10:20 ` Jonas Bernoulli
2020-12-21 14:36 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).