From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
22324@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead)
Date: Wed, 26 Jan 2022 12:19:00 -0500 [thread overview]
Message-ID: <jwvee4ue8na.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <184dffab-4fa4-e265-c8ef-0c088149b1b4@daniel-mendler.de> (Daniel Mendler's message of "Wed, 26 Jan 2022 14:49:48 +0100")
> This sounds like a good idea to solve the issue and retain backward
> compatibility. It is like eating the cake backwards :) A `fail'
> completion style is pretty trivial. It boils down to adding `(fail
> ignore ignore "Fail with no completions")` to the
> `completion-styles-alist`, or did I miss something?
No, because `ignore` will return nil and so we'll just keep going to the
next style. We need try/all-completion functions for this style to
return a non-nil value but that is like "no completion".
I suspect it can't be done quite right without changing `minibuffer.el`,
but we can probably get close enough to be tolerable with older Emacsen.
E.g. for the try-completion case, I think we can return (STRING . POINT)
and for all-completions maybe returning `0` will do the trick.
> I am aware of this distinction, but I chose to ignore it. Calling it
> "quite different" feels like an exaggeration, given that Emacs is
> supposed to be configurable throughout by the user - of course this is
> only my interpretation.
The users are indeed free to mess with anything they like, of course.
But packages are allowed to change `completion-category-defaults`
whereas they're not allowed to change `completion-category-override`.
While we're here, let's not forget the other problem with
`completion-category-defaults` which is when a package puts something
like `substring` in it because `partial-completion` is not "good
enough": this can end up taking precedence over the users's
customization of the default to something like `flex` which is probably
not what's wanted.
I'm not completely sure how to fix that one. An cheap solution would be
to allow `completion-category-defaults` to specify a function rather
than a list of styles, and then this function will return the list of
styles to use so it can dynamically adapt to the user's chosen default.
But it's kind of a cop out because that function will need to "guess"
what is the relationship between the various styles, which is the crux
of the matter.
This problem doesn't apply to `completion-category-override` since we
can consider it to be the user's responsability to take `completion-styles`
into account when setting `completion-category-override`.
Stefan
next prev parent reply other threads:[~2022-01-26 17:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 20:27 bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Dmitry Gutov
2016-01-08 12:17 ` Eli Zaretskii
2016-01-08 12:21 ` Dmitry Gutov
2016-01-08 12:26 ` Eli Zaretskii
2016-01-08 12:30 ` Dmitry Gutov
2016-01-08 15:31 ` Eli Zaretskii
2021-12-02 9:10 ` Lars Ingebrigtsen
2021-12-02 9:45 ` Eli Zaretskii
2021-12-06 1:16 ` Dmitry Gutov
2021-12-06 2:25 ` Lars Ingebrigtsen
2021-12-07 1:35 ` Dmitry Gutov
2021-12-07 20:28 ` Lars Ingebrigtsen
2021-12-07 22:46 ` Dmitry Gutov
2021-12-09 1:09 ` Lars Ingebrigtsen
2022-01-21 13:46 ` Lars Ingebrigtsen
2022-01-24 2:03 ` Dmitry Gutov
2022-01-24 9:46 ` Lars Ingebrigtsen
2022-01-25 2:27 ` Dmitry Gutov
2022-01-25 12:19 ` Lars Ingebrigtsen
2022-01-26 1:43 ` Dmitry Gutov
2022-01-26 2:31 ` Daniel Mendler
2022-01-26 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 13:49 ` Daniel Mendler
2022-01-26 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-01-26 18:59 ` Daniel Mendler
2022-01-26 22:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 23:32 ` Daniel Mendler
2022-01-27 6:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 2:35 ` Dmitry Gutov
2022-01-28 11:54 ` Daniel Mendler
2022-01-28 16:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 22:06 ` Dmitry Gutov
2022-01-28 23:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-29 1:57 ` Dmitry Gutov
2022-01-28 2:37 ` Dmitry Gutov
2022-01-28 16:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 21:23 ` Dmitry Gutov
2022-01-28 2:39 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvee4ue8na.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=22324@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).