From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 22324@debbugs.gnu.org
Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead)
Date: Mon, 24 Jan 2022 10:46:51 +0100 [thread overview]
Message-ID: <87ilu94gac.fsf@gnus.org> (raw)
In-Reply-To: <3045ca8b-f5d6-c85e-d170-3fe158fec64e@yandex.ru> (Dmitry Gutov's message of "Mon, 24 Jan 2022 04:03:17 +0200")
Dmitry Gutov <dgutov@yandex.ru> writes:
> So the fix I had in mind looks like:
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index d58c23af8f..0aee55f33c 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1043,7 +1043,7 @@ completion--styles
> (let* ((cat (completion-metadata-get metadata 'category))
> (over (completion--category-override cat 'styles)))
> (if over
> - (delete-dups (append (cdr over) (copy-sequence completion-styles)))
> + (cdr over)
> completion-styles)))
Oh, I see. Hm... that would change the behaviour for those that depend
on this working the old way.
Perhaps it'd make more sense to add a new variable to allow real overrides?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-01-24 9:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 20:27 bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Dmitry Gutov
2016-01-08 12:17 ` Eli Zaretskii
2016-01-08 12:21 ` Dmitry Gutov
2016-01-08 12:26 ` Eli Zaretskii
2016-01-08 12:30 ` Dmitry Gutov
2016-01-08 15:31 ` Eli Zaretskii
2021-12-02 9:10 ` Lars Ingebrigtsen
2021-12-02 9:45 ` Eli Zaretskii
2021-12-06 1:16 ` Dmitry Gutov
2021-12-06 2:25 ` Lars Ingebrigtsen
2021-12-07 1:35 ` Dmitry Gutov
2021-12-07 20:28 ` Lars Ingebrigtsen
2021-12-07 22:46 ` Dmitry Gutov
2021-12-09 1:09 ` Lars Ingebrigtsen
2022-01-21 13:46 ` Lars Ingebrigtsen
2022-01-24 2:03 ` Dmitry Gutov
2022-01-24 9:46 ` Lars Ingebrigtsen [this message]
2022-01-25 2:27 ` Dmitry Gutov
2022-01-25 12:19 ` Lars Ingebrigtsen
2022-01-26 1:43 ` Dmitry Gutov
2022-01-26 2:31 ` Daniel Mendler
2022-01-26 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 13:49 ` Daniel Mendler
2022-01-26 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 18:59 ` Daniel Mendler
2022-01-26 22:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 23:32 ` Daniel Mendler
2022-01-27 6:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 2:35 ` Dmitry Gutov
2022-01-28 11:54 ` Daniel Mendler
2022-01-28 16:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 22:06 ` Dmitry Gutov
2022-01-28 23:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-29 1:57 ` Dmitry Gutov
2022-01-28 2:37 ` Dmitry Gutov
2022-01-28 16:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 21:23 ` Dmitry Gutov
2022-01-28 2:39 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilu94gac.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22324@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).