From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: emacs-pretest-bug@gnu.org, 2092@emacsbugs.donarmstrong.com
Subject: bug#2092: 23.0.60; vc-svn-diff
Date: Sun, 01 Feb 2009 17:39:37 -0500 [thread overview]
Message-ID: <jwvd4e17plj.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> (Nick Roberts's message of "Wed, 28 Jan 2009 19:34:34 +1300 (NZDT)")
> vc-svn-diff fails when oldvers equals (vc-working-revision f).
> In that case "svn diff" executes with no -r argument and only gives
> a diff if the file is locally modified.
That's the right behavior when newvers is nil, isn't it?
> I don't see how it could ever work (please note that I'm not saying that
> it could never work just that I don't see how it could).
I think it was written assuming (incorrectly) that "newvers == nil".
Is the bug fixed if you add (null newvers) to the conjunction?
Stefan
PS: I see you've already removed this code, but I remember we added
specifically upon request from some users, so it would be better to fix
it than to remove it.
next prev parent reply other threads:[~2009-02-01 22:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 6:34 bug#2092: 23.0.60; vc-svn-diff Nick Roberts
2009-02-01 22:39 ` Stefan Monnier [this message]
2009-02-04 11:03 ` Nick Roberts
2009-02-04 19:42 ` Stefan Monnier
2009-02-04 11:10 ` bug#2092: marked as done (23.0.60; vc-svn-diff) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd4e17plj.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2092@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).