From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2092: 23.0.60; vc-svn-diff Date: Sun, 01 Feb 2009 17:39:37 -0500 Message-ID: References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Reply-To: Stefan Monnier , 2092@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233596166 30671 80.91.229.12 (2 Feb 2009 17:36:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2009 17:36:06 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 2092@emacsbugs.donarmstrong.com To: Nick Roberts Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 02 18:37:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LU2iz-0004OB-Lx for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Feb 2009 18:36:46 +0100 Original-Received: from localhost ([127.0.0.1]:57807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2hg-0002C8-V3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Feb 2009 12:35:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU2WH-0006uO-8o for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU2WF-0006sf-4I for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:36 -0500 Original-Received: from [199.232.76.173] (port=43766 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2WE-0006sV-Qz for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54739) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LU2WE-0002t7-1t for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12HNV1w005685; Mon, 2 Feb 2009 09:23:32 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n12HF34p003374; Mon, 2 Feb 2009 09:15:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 02 Feb 2009 17:15:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2092 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12335945852094 (code B ref -1); Mon, 02 Feb 2009 17:15:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 17:09:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12H9fJR002082 for ; Mon, 2 Feb 2009 09:09:43 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:39694) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LU2H4-0008Bm-W8 for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:07:55 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LU2Ij-0000e5-LH for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:09:40 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:15942 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU2Ii-0000dB-Kc for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:09:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAD+3hknO+IQk/2dsb2JhbACBbsozhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,366,1231131600"; d="scan'208";a="33208424" Original-Received: from 206-248-132-36.dsl.teksavvy.com (HELO ceviche.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 02 Feb 2009 12:09:17 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 061EAB4060; Sun, 1 Feb 2009 17:39:37 -0500 (EST) In-Reply-To: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> (Nick Roberts's message of "Wed, 28 Jan 2009 19:34:34 +1300 (NZDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 02 Feb 2009 12:23:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24839 gmane.emacs.pretest.bugs:23828 Archived-At: > vc-svn-diff fails when oldvers equals (vc-working-revision f). > In that case "svn diff" executes with no -r argument and only gives > a diff if the file is locally modified. That's the right behavior when newvers is nil, isn't it? > I don't see how it could ever work (please note that I'm not saying that > it could never work just that I don't see how it could). I think it was written assuming (incorrectly) that "newvers == nil". Is the bug fixed if you add (null newvers) to the conjunction? Stefan PS: I see you've already removed this code, but I remember we added specifically upon request from some users, so it would be better to fix it than to remove it.