unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#350: ido-mode not compatible with url-handler-mode
@ 2008-06-02 20:21 Jared Finder
  2019-10-01 16:20 ` Stefan Kangas
  0 siblings, 1 reply; 10+ messages in thread
From: Jared Finder @ 2008-06-02 20:21 UTC (permalink / raw)
  To: 'bug-gnu-emacs@gnu.org'

[-- Attachment #1: Type: text/plain, Size: 4041 bytes --]

url-handler-mode is awesome!  ido-mode is too, but they are not
compatible with each other.

With url-handler-mode and ido-mode enabled, try typing
http://www.google.com.  ido-mode will not let you type in that url.
You need to use C-f to enter "normal" url handler mode.

  -- MJF

In GNU Emacs 22.2.1 (i386-mingw-nt5.1.2600)  of 2008-03-26 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)' Important settings:
value of $LC_ALL: nil   value of $LC_COLLATE: nil   value of
$LC_CTYPE: nil   value of $LC_MESSAGES: nil   value of $LC_MONETARY:
nil   value of $LC_NUMERIC: nil   value of $LC_TIME: nil   value of
$LANG: ENU   locale-coding-system: cp1252
default-enable-multibyte-characters: t Major mode: Emacs-Lisp/lw Minor
modes in effect:   eldoc-mode: t   url-handler-mode: t
global-balanced-mode: t   balanced-mode: t   hrule-mode: t
global-hi-lock-mode: t   hi-lock-mode: t   c-subword-mode: t
show-paren-mode: t   recentf-mode: t   global-reveal-mode: t
reveal-mode: t   global-c-subword-mode: t   shell-dirtrack-mode: t
cua-mode: t   encoded-kbd-mode: t   tooltip-mode: t
mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t
global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t
unify-8859-on-encoding-mode: t   utf-translate-cjk-mode: t
auto-compression-mode: t   column-number-mode: t   line-number-mode: t
transient-mark-mode: t Recent input: <return> C-x k <return> <apps> w
3 SPC <backspace>  <backspace> <backspace> <backspace> u r l <tab>
<tab>  <tab> v <tab> <return> C-h f u r l <tab> <tab> <tab>  <tab> g
<tab> <tab> <tab> e t SPC u <tab> <tab> <C-backspace>  <C-backspace>
<C-backspace> <C-backspace> <C-backspace>  f i n d SPC u r <tab>
<backspace> <backspace> <C-backspace>  <C-backspace> u r l SPC f <tab>
<tab> i n <tab> <backspace>  l <tab> <return> <down> <down> <down>
<down> <down>  <down> C-x k <return> C-x 1 C-x b <return>
<switch-frame>  <help-echo> <switch-frame> <switch-frame>
<select-window>  <apps> s c r 9 a <tab> <backspace> <backspace> a ;
<tab> <backspace> t <tab> <return> <switch-frame> <apps>  u r l SPC v
<tab> <return> <apps> u r l <tab> <tab>  <tab> v <tab> <return>
<right> <right> <right> <apps>  u r l <tab> <tab> <tab> h <tab>
<return> <right> <right>  <right> <right> <right> <right> <right>
<right> <home>  <S-end> C-c <timeout> C-x C-f C-x C-f <S-home> C-v
<return> <down> <down> <down> <down> <down> <down>  <down> <down>
<down> <down> <down> <down> <down> <down>  C-h f u r l SPC h a n <tab>
SPC <tab> m <tab> <return>  <select-window> <select-window>
<help-echo> <select-window>  <help-echo> <down-mouse-1> <mouse-2>
<help-echo> <help-echo>  <wheel-down> <double-wheel-down> C-x C-f h t
t p :  / / / s <backspace> h t t p <backspace> <backspace>
<backspace> <backspace> <backspace> C-g <down> <up>  <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <down>  <down> <down> <down> <down>
<down> <down> <down> <down>  <down> <M-right> <M-left> <down> <down>
<down> <down>  <down> <down> <down> <down> <down> <down> <down> <down>
<right> <right> <right> <right> <right> <right> <right>  <right>
<right> C-h v <return> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo>  <help-echo>
<help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report> Recent messages: Display version number,
copyright info, and basic help Explain that Emacs has NO WARRANTY Show
the Emacs license (GPL) How to get latest versions of Emacs Lisp
packages distributed separately for use in Emacs Find packages and
features by keyword Full documentation of Emacs features Our doctor
will help you feel better Send e-mail to Emacs maintainers Loading
emacsbug...done

[-- Attachment #2: Type: text/html, Size: 13842 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
@ 2008-09-07 13:48 martin rudalics
  0 siblings, 0 replies; 10+ messages in thread
From: martin rudalics @ 2008-09-07 13:48 UTC (permalink / raw)
  To: 350; +Cc: Jared Finder

 > url-handler-mode is awesome!  ido-mode is too, but they are not
 > compatible with each other.
 >
 > With url-handler-mode and ido-mode enabled, try typing
 > http://www.google.com.  ido-mode will not let you type in that url.

I'm unable to reproduce that here.  Do you mean that in an arbitrary
buffer simply enabling `url-handler-mode' and `ido-mode' impedes you
typing that URL?  Couly you please give a precise step by step
description with emacs -Q?

 > You need to use C-f to enter "normal" url handler mode.

Forward from where?

Thanks, martin







^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
@ 2008-09-07 18:56 Chong Yidong
  2008-09-07 19:28 ` Kim F. Storm
  0 siblings, 1 reply; 10+ messages in thread
From: Chong Yidong @ 2008-09-07 18:56 UTC (permalink / raw)
  To: Kim F. Storm; +Cc: Jared Finder, 350

> url-handler-mode is awesome!  ido-mode is too, but they are not
> compatible with each other.
>
> With url-handler-mode and ido-mode enabled, try typing
> http://www.google.com [in the C-x C-f prompt].  ido-mode will not let
> you type in that url.  You need to use C-f to enter "normal" url
> handler mode.

Hi Kim,

Here's a bug report about ido-mode.  Do you have time to take a look at
it?  If not, suggestions about how to fix the problem would be welcome.






^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2008-09-07 18:56 bug#350: ido-mode not compatible with url-handler-mode Chong Yidong
@ 2008-09-07 19:28 ` Kim F. Storm
  2013-07-13  5:21   ` Leo Liu
  0 siblings, 1 reply; 10+ messages in thread
From: Kim F. Storm @ 2008-09-07 19:28 UTC (permalink / raw)
  To: Chong Yidong; +Cc: Jared Finder, 350

Chong Yidong <cyd@stupidchicken.com> writes:

>> url-handler-mode is awesome!  ido-mode is too, but they are not
>> compatible with each other.
>>
>> With url-handler-mode and ido-mode enabled, try typing
>> http://www.google.com [in the C-x C-f prompt].  ido-mode will not let
>> you type in that url.  You need to use C-f to enter "normal" url
>> handler mode.
>
> Hi Kim,
>
> Here's a bug report about ido-mode.  Do you have time to take a look at
> it?  If not, suggestions about how to fix the problem would be welcome.

Hi Chong

Ido already has code to deal sensibly with tramp syntax.  It does this
by calling tramp to return completions for a given input matching a
tramp-like filename.

Maybe there is a similar way to do that for the url package, by
checking the input against url-handler-regexp, and calling the
url package's completion functions.

Unfortunately, those are unimplemented, so there really isn't much
ido can do to "improve" url-handler-mode:

(defun url-file-name-completion (url directory)
  (error "Unimplemented"))

(defun url-file-name-all-completions (file directory)
  (error "Unimplemented"))



This is a major reason why ido provides the C-f fallback to standard
"find-file"; then you can enter stuff which doesn't have a reasonable
ido semantics.

So really there is no bug here - it's one of the IMO very minor
problems of using ido.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk







^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2008-09-07 19:28 ` Kim F. Storm
@ 2013-07-13  5:21   ` Leo Liu
  2013-07-13 20:07     ` Stefan Monnier
  0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-07-13  5:21 UTC (permalink / raw)
  To: Kim F. Storm; +Cc: Jared Finder, 350

On 2008-09-08 03:28 +0800, Kim F. Storm wrote:
> So really there is no bug here - it's one of the IMO very minor
> problems of using ido.

I intend to close this bug if no one objects.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2013-07-13  5:21   ` Leo Liu
@ 2013-07-13 20:07     ` Stefan Monnier
  2013-07-14  3:07       ` Leo Liu
  0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2013-07-13 20:07 UTC (permalink / raw)
  To: Leo Liu; +Cc: Jared Finder, 350, Kim F. Storm

>> So really there is no bug here - it's one of the IMO very minor
>> problems of using ido.
> I intend to close this bug if no one objects.

No, it should be fixed instead.  The fix is pretty simple: make
url-file-name-completion and url-file-name-all-completions return
a valid value which represents the fact that we don't know what could be
the completions ("everything could be a valid completion") instead of
signaling an error.


        Stefan





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2013-07-13 20:07     ` Stefan Monnier
@ 2013-07-14  3:07       ` Leo Liu
  2013-07-15 23:48         ` Stefan Monnier
  0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-07-14  3:07 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Jared Finder, 350, Kim F. Storm

On 2013-07-14 04:07 +0800, Stefan Monnier wrote:
> No, it should be fixed instead.  The fix is pretty simple: make
> url-file-name-completion and url-file-name-all-completions return
> a valid value which represents the fact that we don't know what could be
> the completions ("everything could be a valid completion") instead of
> signaling an error.

Do you mean removing all of the following in url-handlers.el?

,----
| (defun url-file-name-completion (url directory &optional predicate)
|   (error "Unimplemented"))
| (put 'file-name-completion 'url-file-handlers 'url-file-name-completion)
| 
| (defun url-file-name-all-completions (file directory)
|   (error "Unimplemented"))
| (put 'file-name-all-completions
|      'url-file-handlers 'url-file-name-all-completions)
`----

Also, url-handler-regexp and tramp's syntax seems colliding.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2013-07-14  3:07       ` Leo Liu
@ 2013-07-15 23:48         ` Stefan Monnier
  0 siblings, 0 replies; 10+ messages in thread
From: Stefan Monnier @ 2013-07-15 23:48 UTC (permalink / raw)
  To: Leo Liu; +Cc: Jared Finder, 350, Kim F. Storm

>> No, it should be fixed instead.  The fix is pretty simple: make
>> url-file-name-completion and url-file-name-all-completions return
>> a valid value which represents the fact that we don't know what could be
>> the completions ("everything could be a valid completion") instead of
>> signaling an error.
> Do you mean removing all of the following in url-handlers.el?

You could start with that and see how it behaves (maybe it won't work
right either since it would presumably call those functions with the URL
as if it were a local file, better might be to keep the code but make
the functions return a "correct" value).

> Also, url-handler-regexp and tramp's syntax seems colliding.

Never had a problem with that.


        Stefan





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2008-06-02 20:21 Jared Finder
@ 2019-10-01 16:20 ` Stefan Kangas
  2019-10-01 17:11   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 10+ messages in thread
From: Stefan Kangas @ 2019-10-01 16:20 UTC (permalink / raw)
  To: Jared Finder; +Cc: 350

Jared Finder <jfinder@crypticstudios.com> writes:

> url-handler-mode is awesome!  ido-mode is too, but they are not
> compatible with each other.
>
> With url-handler-mode and ido-mode enabled, try typing
> http://www.google.com.  ido-mode will not let you type in that url.
> You need to use C-f to enter "normal" url handler mode.

If the long-term plan now is to phase out the entire url library,
perhaps we should close this as wontfix?

Best regards,
Stefan Kangas





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#350: ido-mode not compatible with url-handler-mode
  2019-10-01 16:20 ` Stefan Kangas
@ 2019-10-01 17:11   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 10+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-01 17:11 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Jared Finder, 350

Stefan Kangas <stefan@marxist.se> writes:

> Jared Finder <jfinder@crypticstudios.com> writes:
>
>> url-handler-mode is awesome!  ido-mode is too, but they are not
>> compatible with each other.
>>
>> With url-handler-mode and ido-mode enabled, try typing
>> http://www.google.com.  ido-mode will not let you type in that url.
>> You need to use C-f to enter "normal" url handler mode.
>
> If the long-term plan now is to phase out the entire url library,
> perhaps we should close this as wontfix?

url-handler-mode is something I haven't examined closely, but I think
it's something that's kinda separate from the main url.el, and should be
reimplemented on top of the new URL interface in Emacs 28-ish.  As such,
this bug sounds like it would still be a bug then, so it's something
that should be fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-10-01 17:11 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-07 18:56 bug#350: ido-mode not compatible with url-handler-mode Chong Yidong
2008-09-07 19:28 ` Kim F. Storm
2013-07-13  5:21   ` Leo Liu
2013-07-13 20:07     ` Stefan Monnier
2013-07-14  3:07       ` Leo Liu
2013-07-15 23:48         ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2008-09-07 13:48 martin rudalics
2008-06-02 20:21 Jared Finder
2019-10-01 16:20 ` Stefan Kangas
2019-10-01 17:11   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).