bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Simen Heggestøyl]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Hi. The attached patch fixes the compilation warnings in yasnippet.el
when compiling with Emacs 29.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-compilation-warnings-in-Emacs-29.patch --]
[-- Type: text/x-diff, Size: 3390 bytes --]

From a5a9254f35dd85f6b945fc274fd020e887949e07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
Date: Sun, 5 Mar 2023 08:44:01 +0100
Subject: [PATCH] Fix compilation warnings in Emacs 29

---
 yasnippet.el | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/yasnippet.el b/yasnippet.el
index 78ef38ac39..0129087805 100644
--- a/yasnippet.el
+++ b/yasnippet.el
@@ -476,14 +476,15 @@ See also Info node `(elisp) Syntax Descriptors'.")
   '()
   "Hooks to run after a snippet exited.
 
-The hooks will be run in an environment where some variables bound to
-proper values:
+The hooks will be run in an environment where some variables are
+bound to proper values:
 
 `yas-snippet-beg' : The beginning of the region of the snippet.
 
 `yas-snippet-end' : Similar to beg.
 
-Attention: These hooks are not run when exiting nested/stacked snippet expansion!")
+Attention: These hooks are not run when exiting nested/stacked
+snippet expansion!")
 
 (defvar yas-before-expand-snippet-hook
   '()
@@ -555,7 +556,7 @@ conditions.
     sexp))
 
 (defcustom yas-keymap-disable-hook nil
-  "The `yas-keymap' bindings are disabled if any function in this list returns non-nil.
+  "Disable `yas-keymap' bindings if any function in this list returns non-nil.
 This is useful to control whether snippet navigation bindings
 override bindings from other packages (e.g., `company-mode')."
   :type 'hook)
@@ -1813,7 +1814,8 @@ Optional PROMPT sets the prompt to use."
 SNIPPETS is a list of snippet definitions, each taking the
 following form
 
- (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE KEYBINDING UUID SAVE-FILE)
+ (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE
+  KEYBINDING UUID SAVE-FILE)
 
 Within these, only KEY and TEMPLATE are actually mandatory.
 
@@ -2980,7 +2982,7 @@ marks it as something else (typically comment ender)."
     'again))
 
 (defun yas-longest-key-from-whitespace (start-point)
-  "As `yas-key-syntaxes' element, look for longest key between point and whitespace.
+  "As `yas-key-syntaxes' element, find longest key between point and whitespace.
 
 A newline will be considered whitespace even if the mode syntax
 marks it as something else (typically comment ender)."
@@ -3728,8 +3730,8 @@ Use as a `:filter' argument for a conditional keybinding."
   "Clears unmodified field if at field start, skips to next tab.
 
 Otherwise deletes a character normally by calling `delete-char'."
-  (interactive)
   (declare (obsolete "Bind to `yas-maybe-skip-and-clear-field' instead." "0.13"))
+  (interactive)
   (cond ((yas--maybe-clear-field-filter t)
          (yas--skip-and-clear (or field (yas-current-field)))
          (yas-next-field 1))
@@ -4740,9 +4742,11 @@ The following count as a field:
 * \"${n: text}\", for a numbered field with default text, as long as N is not 0;
 
 * \"${n: text$(expression)}, the same with a Lisp expression;
-  this is caught with the curiously named `yas--multi-dollar-lisp-expression-regexp'
+  this is caught with the curiously named
+  `yas--multi-dollar-lisp-expression-regexp'
 
-* the same as above but unnumbered, (no N:) and number is calculated automatically.
+* the same as above but unnumbered, (no N:) and number is
+  calculated automatically.
 
 When multiple expressions are found, only the last one counts."
   ;;
-- 
2.39.1


[-- Attachment #3: Type: text/plain, Size: 10 bytes --]


-- Simen

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Kangas]

Simen Heggestøyl <simenheg@runbox.com> writes:

> Hi. The attached patch fixes the compilation warnings in yasnippet.el
> when compiling with Emacs 29.

Hmm.  Yasnippet seems to be maintained on Github these days, and AFAIU
we pull from there automatically.  Wouldn't installing it directly on
elpa.git lead to conflicts?

Could someone with access perhaps just push this patch to yasnippet on GitHub?

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> Hi. The attached patch fixes the compilation warnings in yasnippet.el
>> when compiling with Emacs 29.
> Hmm.  Yasnippet seems to be maintained on Github these days, and AFAIU
> we pull from there automatically.  Wouldn't installing it directly on
> elpa.git lead to conflicts?

Yes, please don't push to `elpa.git` directly (at least as long as the
`:url` isn't nil in `elpa-packages`).

> Could someone with access perhaps just push this patch to yasnippet on GitHub?

I have more pending patches on `scratch/yasnippet` so you could push
yours there, and then try and get someone at the upstream to pay
attention to it?
[ See https://github.com/joaotavora/yasnippet/issues/1167  ]


        Stefan

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[João Távora]

On Fri, Sep 1, 2023 at 10:10 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> >> Hi. The attached patch fixes the compilation warnings in yasnippet.el
> >> when compiling with Emacs 29.
> > Hmm.  Yasnippet seems to be maintained on Github these days, and AFAIU
> > we pull from there automatically.  Wouldn't installing it directly on
> > elpa.git lead to conflicts?
>
> Yes, please don't push to `elpa.git` directly (at least as long as the
> `:url` isn't nil in `elpa-packages`).
>
> > Could someone with access perhaps just push this patch to yasnippet on GitHub?
>
> I have more pending patches on `scratch/yasnippet` so you could push
> yours there, and then try and get someone at the upstream to pay
> attention to it?
> [ See https://github.com/joaotavora/yasnippet/issues/1167  ]

People, I have to say I don't pay much attention to yasnippet these days.
I'm not the maintainer anymore, but Noam has also been absent for quite some
time.  I think it's time I archive the repository and it lives on in
elpa.git.

Then you can push this and all and other patches there.

WDYT?

João

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> People, I have to say I don't pay much attention to yasnippet these days.
> I'm not the maintainer anymore, but Noam has also been absent for quite some
> time.  I think it's time I archive the repository and it lives on in
> elpa.git.
>
> Then you can push this and all and other patches there.

That would be fine by me (even better if the Github repository can
redirect people to `elpa.gnu.org` or something like that :-).

Noam?


        Stefan

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Kangas]

João Távora <joaotavora@gmail.com> writes:

> People, I have to say I don't pay much attention to yasnippet these days.
> I'm not the maintainer anymore, but Noam has also been absent for quite some
> time.  I think it's time I archive the repository and it lives on in
> elpa.git.
>
> Then you can push this and all and other patches there.

Another alternative would be to see if there's anyone in the community
that's willing to take over its maintenance, if Noam is indeed no
longer up for it.  I think the cool kids these days put up an
advertisement on Reddit, or something like that.  The less hip option
is to announce it in the project README.  As we were recently reminded
on emacs-devel, you could even send some link to Sacha for the Emacs
newsletter.

Whichever way you decide to go, there are a couple of probably
easy-to-merge patches in the pull requests on GitHub.  Maybe you'd
want to click "Merge" on a few of those first.

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

On Sat, Sep 2, 2023, 00:59 Stefan Kangas <stefankangas@gmail.com> wrote:

> João Távora <joaotavora@gmail.com> writes:
>
> > People, I have to say I don't pay much attention to yasnippet these days.
> > I'm not the maintainer anymore, but Noam has also been absent for quite
> some
> > time.  I think it's time I archive the repository and it lives on in
> > elpa.git.
> >
> > Then you can push this and all and other patches there.
>
> Another alternative would be to see if there's anyone in the community
> that's willing to take over its maintenance, if Noam is indeed no
> longer up for it.  I think the cool kids these days put up an
> advertisement on Reddit, or something like that.  The less hip option
> is to announce it in the project README.  As we were recently reminded
> on emacs-devel, you could even send some link to Sacha for the Emacs
> newsletter.
>

Any of those is fine with me.

>
> Whichever way you decide to go, there are a couple of probably
> easy-to-merge patches in the pull requests on GitHub.  Maybe you'd
> want to click "Merge" on a few of those first.
>

Can you make a list of the safest/most important ones? (keeping on mind
things like backward-compatibility, etc...).

João

>

[-- Attachment #2: Type: text/html, Size: 2157 bytes --]

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Kangas]

João Távora <joaotavora@gmail.com> writes:

> Can you make a list of the safest/most important ones? (keeping on mind
> things like backward-compatibility, etc...).

I don't have the bandwidth for a detailed list right now.

This was an easy one I spotted:

    https://github.com/joaotavora/yasnippet/pull/1125

This one enabling lexical-binding might be a bit more work, or no work.
No idea which.  It would be nice to have, in any case:

    https://github.com/joaotavora/yasnippet/pull/1053

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> This one enabling lexical-binding might be a bit more work, or no work.
> No idea which.  It would be nice to have, in any case:
>
>     https://github.com/joaotavora/yasnippet/pull/1053

The code up on `scratch/yasnippet` (inside `elpa.git`) also activates
lexical-binding (tho I can't remember if it actively makes use of it in
a way that makes it incompatible with Emacs-23).


        Stefan

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Another alternative would be to see if there's anyone in the community
> that's willing to take over its maintenance, if Noam is indeed no
> longer up for it.  I think the cool kids these days put up an
> advertisement on Reddit, or something like that.  The less hip option
> is to announce it in the project README.  As we were recently reminded
> on emacs-devel, you could even send some link to Sacha for the Emacs
> newsletter.

This is actually not mutually exclusive with closing João's repository
and moving to `elpa.git`, since whenever we find new maintainers they
can still use whichever location they like for their upstream repository.


        Stefan

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[João Távora]

On Mon, Sep 4, 2023 at 10:18 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > Another alternative would be to see if there's anyone in the community
> > that's willing to take over its maintenance, if Noam is indeed no
> > longer up for it.  I think the cool kids these days put up an
> > advertisement on Reddit, or something like that.  The less hip option
> > is to announce it in the project README.  As we were recently reminded
> > on emacs-devel, you could even send some link to Sacha for the Emacs
> > newsletter.
>
> This is actually not mutually exclusive with closing João's repository
> and moving to `elpa.git`, since whenever we find new maintainers they
> can still use whichever location they like for their upstream repository.

Yes, I'll move the repo definitely, maybe with a similar arrangement to
Eglot so at least the "GitHub pages" -- which is where the documentation
is served from -- remains alive.

João

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Yes, I'll move the repo definitely, maybe with a similar arrangement to
> Eglot so at least the "GitHub pages" -- which is where the documentation
> is served from -- remains alive.

Sounds good.  Keeping existing links working is good.
The only important thing is to try and avoid people forking that "old"
code rather than starting from the "brand new code" that will be in
`elpa.git` (presumably the differences will be minor, at least for
the foreseeable future, but still).


        Stefan

bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29

[João Távora]

On Sat, Sep 2, 2023 at 8:14 PM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> > Can you make a list of the safest/most important ones? (keeping on mind
> > things like backward-compatibility, etc...).
>
> I don't have the bandwidth for a detailed list right now.
>
> This was an easy one I spotted:
>
>     https://github.com/joaotavora/yasnippet/pull/1125


Thanks, I merged that one and it indeed fixes the all test failures
on Emacs28.

I still have two new test failures on latest Emacs and I suspect
it's something to do with overlay changes.

Stefan Monnier can you have a look maybe?  Could be related to your
overlay changes?

With Emacs 28 this passes:

   emacs -Q --batch -L . -l yasnippet-tests.el --eval
'(ert-run-tests-batch-and-exit "issue-824")'

With latest master it doesn't.  The issue seems to be a call to
yas-active-snippets which calls overlays-in in where BEG and END
are 1 and which returns no overlays because they have mysteriously
evaporated.  But there are no overlays with 'evaporate' properties
that I can detect.

João