From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Gemini Lasswell <gazally@runbox.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
46573@debbugs.gnu.org
Subject: bug#46573: 28.0.50; Error when edebugging setting unbound place
Date: Wed, 03 Mar 2021 18:26:12 -0500 [thread overview]
Message-ID: <jwvblbzomd9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ft1bn84f.fsf@web.de> (Michael Heerdegen's message of "Thu, 04 Mar 2021 00:13:36 +0100")
>> >> I checked older Emacs versions -- (setf foo 'bar) works in Emacs 26.1,
>> >> but not in Emacs 27.1.
>> > Then we should try fixing it in Emacs 27.2, if that's possible without
>> > risky changes.
>>
>> I plan to install the patch below into `master` to fix this problem, but
>> I believe this change is sufficiently safe for the `emacs-27` branch, so
>> you agree I'll install it into `emacs-27` instead.
>
> I tried your patch (thanks for working on it) now. The error is gone,
> but in my example
>
> (setf y 3)
>
> when I step with edebug the thing still stops after the "y" to say the
> value is "3", not after the number "3" - that position is omitted. Is
> this intentional?
Intentional, maybe not, but expected yes: the instrumentation adds
a "before" step right before the "GV assignment" itself and an "after"
step right after it.
Maybe we should add a special case for when `setf` is used for
a simple variable such that the variable is not instrumented at all,
just as is the case for `setq`?
Stefan
next prev parent reply other threads:[~2021-03-03 23:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:32 bug#46573: 28.0.50; Error when edebugging setting unbound place Michael Heerdegen
2021-02-16 22:51 ` Lars Ingebrigtsen
2021-02-16 23:04 ` Stefan Monnier
2021-02-16 23:09 ` Lars Ingebrigtsen
2021-02-16 23:19 ` Lars Ingebrigtsen
2021-02-16 23:21 ` Lars Ingebrigtsen
2021-02-17 15:29 ` Eli Zaretskii
2021-03-01 21:17 ` Stefan Monnier
2021-03-02 5:58 ` Eli Zaretskii
2021-03-05 17:39 ` Stefan Monnier
2021-03-03 23:13 ` Michael Heerdegen
2021-03-03 23:26 ` Stefan Monnier [this message]
2021-03-03 23:47 ` Michael Heerdegen
2021-02-17 0:00 ` Stefan Monnier
2021-02-24 0:59 ` Gemini Lasswell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvblbzomd9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46573@debbugs.gnu.org \
--cc=gazally@runbox.com \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).