From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46573: 28.0.50; Error when edebugging setting unbound place Date: Wed, 03 Mar 2021 18:26:12 -0500 Message-ID: References: <87v9ar1w4l.fsf@web.de> <87mtw3r5hr.fsf@gnus.org> <8735xvr4o2.fsf@gnus.org> <87y2fnppn5.fsf@gnus.org> <87r1lfppjm.fsf@gnus.org> <83r1le7lwg.fsf@gnu.org> <87ft1bn84f.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38979"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gemini Lasswell , Lars Ingebrigtsen , 46573@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 00:27:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHati-000A0X-FY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 00:27:18 +0100 Original-Received: from localhost ([::1]:55060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHath-00034w-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 18:27:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHatS-00034i-4b for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 18:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHatR-0006bi-Tv for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 18:27:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHatR-0000GP-PL for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 18:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2021 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46573 X-GNU-PR-Package: emacs Original-Received: via spool by 46573-submit@debbugs.gnu.org id=B46573.1614813984967 (code B ref 46573); Wed, 03 Mar 2021 23:27:01 +0000 Original-Received: (at 46573) by debbugs.gnu.org; 3 Mar 2021 23:26:24 +0000 Original-Received: from localhost ([127.0.0.1]:57223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHasp-0000FX-MJ for submit@debbugs.gnu.org; Wed, 03 Mar 2021 18:26:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHasn-0000FL-Tw for 46573@debbugs.gnu.org; Wed, 03 Mar 2021 18:26:22 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 32803441E44; Wed, 3 Mar 2021 18:26:16 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AA065441E41; Wed, 3 Mar 2021 18:26:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614813974; bh=oG2Xxru5xS8T6JaP34wxNZz8/VFH/uk4hDlQYArSj3s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QvxRNDkdrX9twha6arWefdqtLg8PVOMj2yJsXwKe3YuUjHl8fiF35O5cLu+vQb6J8 Vx9P/gOqrCFMHxkVjwq4P1m7I2LkZ+PYT1L/7g2HUwI2ofc9yHvefFNZbEA+kzFZ1P iCgV5dLZ1y9AfSIFLXW+yVSrhpnXscWuCg2hYnQ7bJkSE/yheSZjp2A5tpj31Z0oMH RvLmeDs/eTy44/wzxfrN0GCkxd8SRud5KdDCU6EAq+D+P13UfdREdPz5mr/AltHnYU 0g93oo1EPi0kvPdSdYOHSrCyCFSigPcfAEREVejj8+uRuNHBorVwK1L3qeVdIHTW3r IQtrz2VwwUoXA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A07DC1201E0; Wed, 3 Mar 2021 18:26:14 -0500 (EST) In-Reply-To: <87ft1bn84f.fsf@web.de> (Michael Heerdegen's message of "Thu, 04 Mar 2021 00:13:36 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201340 Archived-At: >> >> I checked older Emacs versions -- (setf foo 'bar) works in Emacs 26.1, >> >> but not in Emacs 27.1. >> > Then we should try fixing it in Emacs 27.2, if that's possible without >> > risky changes. >> >> I plan to install the patch below into `master` to fix this problem, but >> I believe this change is sufficiently safe for the `emacs-27` branch, so >> you agree I'll install it into `emacs-27` instead. > > I tried your patch (thanks for working on it) now. The error is gone, > but in my example > > (setf y 3) > > when I step with edebug the thing still stops after the "y" to say the > value is "3", not after the number "3" - that position is omitted. Is > this intentional? Intentional, maybe not, but expected yes: the instrumentation adds a "before" step right before the "GV assignment" itself and an "after" step right after it. Maybe we should add a special case for when `setf` is used for a simple variable such that the variable is not instrumented at all, just as is the case for `setq`? Stefan