From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: 66032@debbugs.gnu.org, drew.adams@oracle.com
Subject: bug#66032: [PATCH] Inline advice documentation into advised function's docstring, after all
Date: Mon, 18 Sep 2023 18:19:57 -0400 [thread overview]
Message-ID: <jwvbkdzcekv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h6nr19f3.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Mon, 18 Sep 2023 23:03:12 +0200")
> I have been trying to understand these quirks and previous bugs of
> functions `advice--make-single-doc' and `advice--make-docstring' better,
> also to probably provide some ERT tests, and would like to focus on one
> issue I came across. Namely, it seems that your work-around:
>
> ;; Hack attack! For advices installed before calling
> ;; Snarf-documentation, the integer offset into the DOC file will not
> ;; be installed in the "core unadvised function" but in the advice
> ;; object instead! So here we try to undo the damage.
> (when (integerp (aref flist 4))
> (setq docfun flist))
>
> is no longer efficient.
Indeed, this is not needed any more (since we don't use pre-dump advice
any more) nor is it working (ever since nadvice.el was made to use OClosures).
> (Snarf-documentation "DOC")
>
> I get a message
>
> Docstring slot busy for rename-buffer
[ BTW, I consider this to a be long standing bug in
`Snarf-documentation`. But since it's very unusual to call this
function after dumping, it's a low-priority issue. ]
Stefan
next prev parent reply other threads:[~2023-09-18 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 12:57 bug#66032: [PATCH] Inline advice documentation into advised function's docstring, after all Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 15:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 17:15 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-17 20:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 21:03 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 22:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-23 8:07 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-23 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-23 19:09 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-23 22:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbkdzcekv.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=66032@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=jschmidt4gnu@vodafonemail.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).