From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66032: [PATCH] Inline advice documentation into advised function's docstring, after all Date: Mon, 18 Sep 2023 18:19:57 -0400 Message-ID: References: <87led6ghu8.fsf@sappc2.fritz.box> <87h6nr19f3.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66032@debbugs.gnu.org, drew.adams@oracle.com To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 19 00:22:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiMd7-00021t-NM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Sep 2023 00:22:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiMct-0002Qq-KK; Mon, 18 Sep 2023 18:21:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiMcs-0002Qa-6P for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 18:21:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiMcr-0003jM-Uz for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 18:21:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiMd0-0003sQ-CR for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 18:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66032-submit@debbugs.gnu.org id=B66032.169507569414861 (code B ref 66032); Mon, 18 Sep 2023 22:22:02 +0000 Original-Received: (at 66032) by debbugs.gnu.org; 18 Sep 2023 22:21:34 +0000 Original-Received: from localhost ([127.0.0.1]:54867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiMcY-0003rc-4H for submit@debbugs.gnu.org; Mon, 18 Sep 2023 18:21:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiMcT-0003rK-3D for 66032@debbugs.gnu.org; Mon, 18 Sep 2023 18:21:32 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C89B91000A3; Mon, 18 Sep 2023 18:21:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1695075673; bh=N2i6H9Fhjt0FAPbeZSLWnHOrls71OIfyYBK9oEHGcVk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=izvHh3q4hcKL74ru0lCClfYtwLhHNQGpP5UmPjMl3vLwXWdflQl4YDifQYrT9LVvF xN6jUFa6/yl9A6ZgpEr5NTwyjsuAtHxEx3r82+Lh5vzP7Tyen3gGhcGvRhSLZVUxNv AoynViuSbHryv8zFL+UWYpTst2RhzbSDq7Dpyt8NPo2AQKlr1yb7PnN78XfDNwwGhT 5IXvZWq7JN57A0YLLzELZqRVjmGR7uhFy3+sPu21P+BdMPAo+1ADEWKpNEt7yw2axV 6hZgxBODRQz9j1bPOlmNrFUcgQYTYIDOybVaPCRrwXM9ceWZTw+Xzs9LBI4+j9gdmA 67NY3488BIZdA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9C9AA100046; Mon, 18 Sep 2023 18:21:13 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8D0F31202AD; Mon, 18 Sep 2023 18:21:13 -0400 (EDT) In-Reply-To: <87h6nr19f3.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Mon, 18 Sep 2023 23:03:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270845 Archived-At: > I have been trying to understand these quirks and previous bugs of > functions `advice--make-single-doc' and `advice--make-docstring' better, > also to probably provide some ERT tests, and would like to focus on one > issue I came across. Namely, it seems that your work-around: > > ;; Hack attack! For advices installed before calling > ;; Snarf-documentation, the integer offset into the DOC file will not > ;; be installed in the "core unadvised function" but in the advice > ;; object instead! So here we try to undo the damage. > (when (integerp (aref flist 4)) > (setq docfun flist)) > > is no longer efficient. Indeed, this is not needed any more (since we don't use pre-dump advice any more) nor is it working (ever since nadvice.el was made to use OClosures). > (Snarf-documentation "DOC") > > I get a message > > Docstring slot busy for rename-buffer [ BTW, I consider this to a be long standing bug in `Snarf-documentation`. But since it's very unusual to call this function after dumping, it's a low-priority issue. ] Stefan