bug#20282: css-mode: multiple selectors *sometimes* breaks indentation

bug#20282: css-mode: multiple selectors *sometimes* breaks indentation

[Darren Embry]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

The following rather simple example of a chunk of CSS:

    a, b:hover {
           color: black;
       }

gets indented incorrectly.  The second line gets indented seven spaces
instead of four; the last gets three spaces instead of zero.

In this more complex example, the closing bracket lines up with the 'j':

    a.b:c,d.e:f,g[h]:i,j[k]:l,.m.n:o,.p.q:r,.s[t]:u,.v[w]:x {
  background-color: white;
                       }

This example, however, is indented just fine:

    a, b:hover, c {
        color: black;
    }

I've tried this in emacs-24.4 and emacs-24.5-rc3 on Linux, as well as 24.4
on the Windows platform.

Regards,
Darren

[-- Attachment #2: Type: text/html, Size: 1559 bytes --]

bug#20282: css-mode: multiple selectors *sometimes* breaks indentation

[Stefan Monnier]

> The following rather simple example of a chunk of CSS:
>     a, b:hover {
>            color: black;
>        }
> gets indented incorrectly.

Indeed, thanks.  I installed the patch below which seems to fix
this problem.


        Stefan


diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 7280080..851618c 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -327,6 +327,10 @@
     (`(:elem . basic) css-indent-offset)
     (`(:elem . arg) 0)
     (`(:list-intro . ,(or `";" `"")) t) ;"" stands for BOB (bug#15467).
+    (`(:before . "{")
+     (when (smie-rule-hanging-p)
+       (smie-backward-sexp ";")
+       (smie-indent-virtual)))
     (`(:before . ,(or "{" "("))
      (if (smie-rule-hanging-p) (smie-rule-parent 0)))))