unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 68338@debbugs.gnu.org,
	Gautier Ponsinet <gautier@gautierponsinet.xyz>,
	Manuel Giraud <manuel@ledu-giraud.fr>
Subject: bug#68338: 30.0.50; Repeat mode and input methods
Date: Thu, 11 Jan 2024 22:51:52 -0500	[thread overview]
Message-ID: <jwva5pbnrmk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvfrz3nscx.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 11 Jan 2024 22:31:33 -0500")

> I suspect all it takes is to change the:
>
>                    (not (eq (cadr overriding-terminal-local-map)
>                             universal-argument-map))

BTW, this is hence related to Bug#22958 where we fixed it for the
specific case of `C-u` but we now need to fix it more generally.

> IOW define something like a `keymap-transient-p` function, use it there,
> and make sure the keymaps installed by `set-transient-map` are recognized
> by that new function.

Maybe we can treat all `overriding-terminal-local-map` as "transient" in
this respect, as in the patch below.

It's a bit risky, admittedly.  But it would be useful to know what
breaks when we do that, to get a better understanding about what the
condition above should really test.


        Stefan


diff --git a/lisp/international/quail.el b/lisp/international/quail.el
index 56f049aedf5..af1335118a1 100644
--- a/lisp/international/quail.el
+++ b/lisp/international/quail.el
@@ -1324,9 +1324,7 @@ quail-input-method
                ;; binding in `universal-argument-map' just return
                ;; (list KEY), otherwise act as if there was no
                ;; overriding map.
-               (or (not (eq (cadr overriding-terminal-local-map)
-                            universal-argument-map))
-                   (lookup-key overriding-terminal-local-map (vector key))))
+               (lookup-key overriding-terminal-local-map (vector key)))
 	  overriding-local-map)
       (list key)
     (quail-setup-overlays (quail-conversion-keymap))






  reply	other threads:[~2024-01-12  3:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 22:09 bug#68338: 30.0.50; Repeat mode and input methods Gautier Ponsinet
2024-01-09 12:53 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 14:31 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 14:36   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 16:52 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 17:31   ` Eli Zaretskii
2024-01-11  7:10   ` Juri Linkov
2024-01-11 15:16     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12  3:31     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12  3:51       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-12  7:33         ` Juri Linkov
2024-01-18 23:29           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva5pbnrmk.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68338@debbugs.gnu.org \
    --cc=gautier@gautierponsinet.xyz \
    --cc=juri@linkov.net \
    --cc=manuel@ledu-giraud.fr \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).